Remoting and Chrome on iOS both needs MD icons. There are two source for those icons: 1. http://github.com/google/material-design-icons 2. some google internal repository Currently Chrome on iOS track a subset of the icons from 2., and another subset are directly copied in the upstream repository. This causes issues because the icon names conflict and some icons are missing from the internal repository. It would be much simpler to track http://github.com/google/material-design-icons and point downstream code to depend on those. This is also impacting remoting, see for example https://codereview.chromium.org/2940263002/. Discussion document (sorry, googlers only): https://docs.google.com/document/d/15266s0GALBts7Hl-PYmRtH7MdTmhRt-XmXMnQu65sgU/edit
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/febdac76a34c60d4f8210e6f77251e10d31cccb5 commit febdac76a34c60d4f8210e6f77251e10d31cccb5 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Jun 29 18:12:22 2017 Track Material Design Icons. Bug: 734054 Change-Id: I18d5c2eb81f4e968ce27315c53ad0fd3bd6981ac Reviewed-on: https://chromium-review.googlesource.com/538716 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#483423} [modify] https://crrev.com/febdac76a34c60d4f8210e6f77251e10d31cccb5/DEPS [modify] https://crrev.com/febdac76a34c60d4f8210e6f77251e10d31cccb5/third_party/.gitignore [add] https://crrev.com/febdac76a34c60d4f8210e6f77251e10d31cccb5/third_party/material_design_icons/LICENSE [add] https://crrev.com/febdac76a34c60d4f8210e6f77251e10d31cccb5/third_party/material_design_icons/OWNERS [add] https://crrev.com/febdac76a34c60d4f8210e6f77251e10d31cccb5/third_party/material_design_icons/README.chromium
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/943e2ed8dd865bd67418babaaee0d72a20df91c8 commit 943e2ed8dd865bd67418babaaee0d72a20df91c8 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Jun 30 17:47:44 2017 Refactor assets catalog declaration and compilation. Add a template "imageset" to declare compile a single .imageset directory into a bundle compiled asset catalog. This template works by copying the images in a brand new .xcassets bundle in $target_gen_dir and declaring a bundle_data pointing to that .xcassets. Refactor all target declaring .imageset resources to use the new template. This should ensure that only the resources used are in the generated Assets.car file (as the compilation is done at the .xcassets level, so may have included unused resources previously). Refactor target that referenced images copied from the material design icons repository to use the newly tracked resources. Bug: 734054 , 738359 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I629dd2c845b52f6ffbf5a314e570305f9c819592 Reviewed-on: https://chromium-review.googlesource.com/558351 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#483748} [add] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/build/config/ios/dummy.py [add] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/build/config/ios/imageset.gni [modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/components/cronet/ios/BUILD.gn [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/components/cronet/tools/dummy.py [modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/ios/chrome/app/resources/BUILD.gn [modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/ios/chrome/browser/ui/activity_services/BUILD.gn [modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/ios/chrome/browser/ui/downloads/BUILD.gn [modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/ios/chrome/browser/ui/first_run/BUILD.gn [modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/ios/chrome/browser/ui/icons/BUILD.gn [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_arrow_back.imageset/Contents.json [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_arrow_back.imageset/ic_arrow_back.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_arrow_back.imageset/ic_arrow_back_2x.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_arrow_back.imageset/ic_arrow_back_3x.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_chevron_right.imageset/Contents.json [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_chevron_right.imageset/ic_chevron_right.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_chevron_right.imageset/ic_chevron_right_2x.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_chevron_right.imageset/ic_chevron_right_3x.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_close.imageset/Contents.json [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_close.imageset/ic_close.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_close.imageset/ic_close_2x.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_close.imageset/ic_close_3x.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_info.imageset/Contents.json [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_info.imageset/ic_info.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_info.imageset/ic_info_2x.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_info.imageset/ic_info_3x.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_search.imageset/Contents.json [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_search.imageset/ic_search.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_search.imageset/ic_search_2x.png [delete] https://crrev.com/8e99ea8592f73ca32f7b88e3e4e41f21cd0ddd53/ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_search.imageset/ic_search_3x.png [modify] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/ios/chrome/browser/ui/qr_scanner/BUILD.gn [add] https://crrev.com/943e2ed8dd865bd67418babaaee0d72a20df91c8/third_party/material_design_icons/BUILD.gn
Found that some icons do not have a Contents.json file. Filed https://github.com/google/material-design-icons/issues/630 and send pull request https://github.com/google/material-design-icons/pull/631 to fix this. Will require rolling material-design-icons once this lands.
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e1bf5645524c85a0fcda5f03a140398bfcf3ce2c commit e1bf5645524c85a0fcda5f03a140398bfcf3ce2c Author: sdefresne <sdefresne@google.com> Date: Mon Jul 03 14:58:13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8acd94cd41a7ca7f18bf57085d6535a1a9934b97 commit 8acd94cd41a7ca7f18bf57085d6535a1a9934b97 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Jul 10 13:39:32 2017 Use assets from material-design-icons in remoting on iOS. Use assets from material-design-icons on iOS for remoting. Some assets have a different name so update remoting_theme.mm to use the new names. Some assets are unreferenced by the code. They are left as deps because they may be referenced form the private downstream repo. Remove duplicated assets. Bug: 734054 Change-Id: I03a157da73e8730b71e2941b52b1caae56d6c356 Reviewed-on: https://chromium-review.googlesource.com/558357 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#485256} [modify] https://crrev.com/8acd94cd41a7ca7f18bf57085d6535a1a9934b97/remoting/ios/app/BUILD.gn [modify] https://crrev.com/8acd94cd41a7ca7f18bf57085d6535a1a9934b97/remoting/ios/app/remoting_theme.mm [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/Back.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_1x_ios_36dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_2x_ios_36dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_3x_ios_36dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/Settings.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_1x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_2x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_3x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_arrow_forward_white.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_arrow_forward_white.imageset/ic_arrow_forward_white.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_arrow_forward_white.imageset/ic_arrow_forward_white_2x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_arrow_forward_white.imageset/ic_arrow_forward_white_3x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_check_box.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_check_box.imageset/ic_check_box_white_1x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_check_box.imageset/ic_check_box_white_2x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_check_box.imageset/ic_check_box_white_3x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_check_box_outline_blank.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_check_box_outline_blank.imageset/ic_check_box_outline_blank_white_1x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_check_box_outline_blank.imageset/ic_check_box_outline_blank_white_2x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_check_box_outline_blank.imageset/ic_check_box_outline_blank_white_3x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_desktop.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop@2x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop@3x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows@2x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows@3x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen@2x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen@3x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit@2x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit@3x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_menu.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_menu.imageset/ic_menu_white.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_menu.imageset/ic_menu_white_2x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_menu.imageset/ic_menu_white_3x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_mouse.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse@2x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse@3x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_radio_button_checked.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_radio_button_checked.imageset/ic_radio_button_checked_white_1x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_radio_button_checked.imageset/ic_radio_button_checked_white_2x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_radio_button_checked.imageset/ic_radio_button_checked_white_3x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_radio_button_unchecked.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_radio_button_unchecked.imageset/ic_radio_button_unchecked_white_1x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_radio_button_unchecked.imageset/ic_radio_button_unchecked_white_2x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_radio_button_unchecked.imageset/ic_radio_button_unchecked_white_3x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app_2x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app_3x.png [modify] https://crrev.com/8acd94cd41a7ca7f18bf57085d6535a1a9934b97/remoting/ios/app/resources/BUILD.gn [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/system_icons.xcassets/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/system_icons.xcassets/ic_close.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/system_icons.xcassets/ic_close.imageset/ic_close_white_1x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/system_icons.xcassets/ic_close.imageset/ic_close_white_2x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/system_icons.xcassets/ic_close.imageset/ic_close_white_3x_ios_24dp.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/system_icons.xcassets/ic_refresh.imageset/Contents.json [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/system_icons.xcassets/ic_refresh.imageset/ic_refresh_white.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/system_icons.xcassets/ic_refresh.imageset/ic_refresh_white_2x.png [delete] https://crrev.com/830f3799083798d9b76119b4ea0130976f945940/remoting/ios/app/resources/system_icons.xcassets/ic_refresh.imageset/ic_refresh_white_3x.png [modify] https://crrev.com/8acd94cd41a7ca7f18bf57085d6535a1a9934b97/third_party/material_design_icons/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d45469f31c9c353f72a4de9df46360e7f23077e9 commit d45469f31c9c353f72a4de9df46360e7f23077e9 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Jul 19 18:39:19 2017 Roll material-design-icons to 5ab428852e35dc177a8c37a2df9dc9ccf768c65a. Commit 5ab428852e35dc177a8c37a2df9dc9ccf768c65a adds Contents.json for all .imageset in the material-design-icons that are required for asset catalog compilation. Add //third_party/material_design_icons:ic_touch_app as a dependency of //remoting/ios/app/resources:assets as it is now fixed. Bug: 734054 Change-Id: Icc4e484ba1ed22c1af06a4c074b3d0cf0ba00bf9 Reviewed-on: https://chromium-review.googlesource.com/576037 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#487928} [modify] https://crrev.com/d45469f31c9c353f72a4de9df46360e7f23077e9/DEPS [modify] https://crrev.com/d45469f31c9c353f72a4de9df46360e7f23077e9/remoting/ios/app/resources/BUILD.gn [modify] https://crrev.com/d45469f31c9c353f72a4de9df46360e7f23077e9/third_party/material_design_icons/BUILD.gn
Comment 1 by sdefresne@chromium.org
, Jun 16 2017Status: started (was: Untriaged)