New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734012 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Browse as Guest option is not translated on changing browser language

Project Member Reported by sc00335...@techmahindra.com, Jun 16 2017

Issue description

Chrome Version: 61.0.3132.0 dev
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome and change browser language to any other language say (Arabic/Hindi/Telugu/Tamil)
(2)Now open manage people and observe "Browse As Guest" text

Expected: Text should change as per browser language.
Actual: Instead text is seen in English only.

This is a regression issue broken in M61.

Good Build: 61.0.3131.0 dev
Bad Build: 61.0.3132.0 dev
 
Expected_translation.png
106 KB View Download
Actual_translation.png
119 KB View Download
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue in mac 10.12.5 using chrome version #61.0.3132.0.


Labels: OS-Mac
Cc: jmukthavaram@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable
Owner: wzang@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on Windows 7, Mac 10.12.5 & Ubuntu 14.04 using chrome latest Canary-61.0.3132.0.
Manual Bisect:
-------------
Good Build: 61.0.3131.0 -Revision-479564
Bad Build: 61.0.3132.0 -Revision-479900

Per revision bisect info:
------------------------
You are probably looking for a change made after 479859 (known good), but no later than 479860 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/c6364bafd0fd12c9aae76d7a4aa257ce59db1916..a89cf93013a528e4627bc5d6d06b5889ea4e845d

Possible suspect:
----------------
https://chromium.googlesource.com/chromium/src/+/a89cf93013a528e4627bc5d6d06b5889ea4e845d

wzang@ Could you please take a look & reassign to the right owner if it is not related to your change.
Since it is regressed recently,adding 'Release block stable'. Please remove if it is not the case.
Thanks..!!

Comment 4 by wzang@chromium.org, Jun 16 2017

Cc: wzang@chromium.org
Owner: mahmadi@chromium.org
I believe this is related to this file chrome/browser/resources/md_user_manager/control_bar.html

Assign to mahmadi@ as he is the only owner. Please reassign if it's not the correct file. Thanks.

The above CL is for Chrome OS signin screen use. The string is not in upper case so it's essentially a different string than the one in the screenshot. 
Owner: msarda@chromium.org
I haven't worked on the user manager for a while now. Assigning to msarda@ to triage.

Comment 6 by msarda@chromium.org, Jun 22 2017

Owner: wzang@chromium.org
wzang@: The file https://cs.chromium.org/chromium/src/chrome/browser/resources/md_user_manager/control_bar.html?q=chrome/browser/resources/md_user_manager/control_bar.html+package:%5Echromium$&dr has not changed for over a year. Why do you suspect the problem is from that file?

I also suspect CL https://codereview.chromium.org/2938743002 which changed the string from "Browse as guest" to "Browse as Guest".  Maybe the new string was just not yet translated. I would expect the translation to take some time (the CL landed 1 day before this bugs was filed)

In any case, re-assiging to wzang@, the author of CL https://codereview.chromium.org/2938743002

Comment 7 by wzang@chromium.org, Jun 22 2017

msarda@, sorry it should be due to the translation delay. The file control_bar.html was mentioned in one of your comments in a previous CL when somebody raised the question as to whether changing the texts would affect the Manage People page. I thought what you meant is that this file use a different string. Sorry I misunderstood
Labels: TE-Verified-M61 TE-Verified-61.0.3153.0
Tested this issue on Windows 7, Mac 10.12.5 & Ubuntu 14.04 using latest Canary-61.0.3153.0.

Observed that the text has been changed as per browser language when user click on 'Manage people' section.As it is working as expected,adding TE Verified labels.

Please find the attached screencast for reference.

Thank you..!!


734012.mp4
628 KB View Download

Comment 9 by wzang@chromium.org, Jul 10 2017

Status: Fixed (was: Assigned)

Sign in to add a comment