Issue metadata
Sign in to add a comment
|
Regression : Guest Text is seen missing at Uber Tray on opening 'Join Wi-Fi network' Dialog box |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3130.0/9655.0.0 dev channel Paine,Gnawty and Parrot OS: Chrome What steps will reproduce the problem? (1)Browse as Guest -> Go to chrome://md-settings -> Now under 'Network' section click on 'Wi-Fi' (2)In Wi-Fi page select the connected Network -> Click on 'DISCONNECT' option -> 'CONFIGURE' option is enabled (3)Click on 'CONFIGURE' option so that 'Join Wi-Fi network' Dialog box is seen -> Now click on Uber Tray and observe Guest Text is sen missing(Please refer Video and screenshot) This is Regression issue as same is working fine for 58.0.3029.145/9334.74.0 stable-Channel Parrot @tbuckley : Please confirm the Issue
,
Jun 19 2017
I can repro on 61.0.3130.0 canary / 9653.0.0 @tdanderson any thoughts what happened here?
,
Jun 21 2017
Nothing jumps out at me, sorry. Note this only seems to reproduce for a guest, not a logged-in user. Perhaps +jamescook or +xiyuan have some ideas? Failing that I suggest applying Needs-Bisect and re-assigning back to mmanchala@ for per-revision bisect triage. Note that a per-revision bisect can be performed here in the same way one would perform a per-revision bisect on Linux, but with two changes: * Add the following to your gn args: target_os = "chromeos" * Use the following command line flags to launch in Guest mode: --user-data-dir=/tmp/chrome --bwsi --incognito --login-user='$guest' --login-profile=user
,
Jun 21 2017
emm, somehow UserCardView is created with ash::LoginStatus::LOCKED when wifi config view (system modal dialog) is shown. Let me take a closer look.
,
Jun 21 2017
We are focing LOCKED status for system tray when there is a system modal dialog open in SystemTrayBubble::CreateItemViews [1]. The code might be useful as we should not allow many tray actions while having a system modal dialog. So I will keep it. To fix this issue, it looks like UserCardView should test guest status without using LoginStatus. [1]: https://cs.chromium.org/chromium/src/ash/system/tray/system_tray_bubble.cc?rcl=ea56b8a8d17ddd1fc397c77988ac07f6affea27f&l=313-316
,
Jun 21 2017
Why do we let you open the system tray when a system modal dialog is open? The shelf is disabled. Is it so you can open accessibility settings? Is that something other platforms allow?
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64b6f810d34a81a07754da969330941efe781956 commit 64b6f810d34a81a07754da969330941efe781956 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Wed Jun 21 22:45:04 2017 ash: Create UserCardView from user session info Use user type from user session info instead of LoginStatus when creating UserCardView. The user session info contains the true data of the user. LoginStatus is deprecated and also used to temporarily lock down system tray when there is system modal dialog. BUG= 734011 Change-Id: I295ffaa43fa8a91f0329031758c155a97468e473 Reviewed-on: https://chromium-review.googlesource.com/544035 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#481338} [modify] https://crrev.com/64b6f810d34a81a07754da969330941efe781956/ash/system/user/user_card_view.cc [modify] https://crrev.com/64b6f810d34a81a07754da969330941efe781956/ash/system/user/user_card_view.h [modify] https://crrev.com/64b6f810d34a81a07754da969330941efe781956/ash/system/user/user_view.cc
,
Jun 28 2017
,
Jan 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Jun 16 2017356 KB
356 KB View Download
13.2 MB
13.2 MB View Download