New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 734000 link

Starred by 2 users
Status: Available
Owner:
msarda@chromium.org
Cc:
nyerramilli@chromium.org
kkaluri@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Keyboard shortcut doesn't work when sign-in to chrome overlay is opened.

Reported by dchau...@etouch.net, Jun 16 2017 
Chrome Version: 61.0.3132.0 (Official Build) (cohort: 59_104_Win)407583a866bb1839b09289b5f2e856b15700ea51-refs/heads/master@{#479900}(32/64 Bit).
OS: Windows(7,8,10),Linux (14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome and click on avatar icon at top RHS to open profile bubble.
2. Click on 'Sign in to Chrome' button to open to 'sign in to Chrome' overlay.
3. Now, press 'Ctrl + Shift + Q' key from keyboard and observe.

Actual: Unable to exit the Chrome browser on pressing 'Ctrl + Shift + Q' key from keyboard even able to exit the browser from wrench menu list on clicking 'Exit' option.
Expected: Should be able to exit the Chrome browser on pressing 'Ctrl + Shift + Q' key from keyboard.

Note: 
1. Unable to open wrench menu list in good build (57.0.2978.0)
2. This issue is not seen on Mac OS.

This is a regression issue, broken in M-57 series, below is manual regression range.

Good build: 57.0.2978.0
Bad build: 57.0.2979.0

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
1.1 MB View Download
Good build behavior.mp4
707 KB View Download

Comment 1 by kkaluri@chromium.org, Jun 16 2017

Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: msarda@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 57.0.2978.0,  Revision Range- 442756
Bad build  : 57.0.2979.0,  Revision Range- 443120

After executing the per-revision-bisect script, i got the following CL's between good and bad build versions
============================================
https://chromium.googlesource.com/chromium/src/+log/8b090304788061c3bb4b2d4ca58d0461c01c646c..c713c645abfea6684e7ed83d48ee7c334b3979dd

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/c713c645abfea6684e7ed83d48ee7c334b3979dd

From the above CL suspecting the below change
--------------------------------------
Review-Url: https://codereview.chromium.org/2619963003

msarda@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.


Thank You...

Comment 2 by msarda@chromium.org, Jun 16 2017 

My CL https://codereview.chromium.org/2619963003 did not affect the behavior for the sign-in view (it only changed the behavior for the sync confirmation and sign-in error view).

Does the shortcut work for other tab-modal dialogues?

Comment 3 by dchau...@etouch.net, Jun 16 2017 

With response to comment# 2: Yes, keyboard shortcut works for other tab-model dialog. For ex: keyboard shortcut works for 'Cast' dialog.

Attaching screen-cast for the same.
Cast_dialog_shortcut.mp4
1.3 MB View Download

Comment 4 by msarda@chromium.org, Jun 16 2017 

I do not think that this bug is related to my CL, however it looks like it is related to the sign-in code, so I am the right owner for the bug.

Comment 5 by ew...@chromium.org, Jun 30 2017

Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
This isn't a release blocking bug. Updating priority.

Comment 6 by msarda@chromium.org, Jul 10 2017

Labels: Hotlist-Polish
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 9 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Available)
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 3

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment