New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733994 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.4%-3.5% regression in webrtc_perf_tests at 18580:18581

Project Member Reported by terelius@chromium.org, Jun 16 2017

Issue description

The chromium roll contains a clang update.

sprang@: Is PSNR typically affected by compiler optimizations? Are these changes acceptable or should we dig further?

kjellander@: Should we file feedback to the clang team when we get regressions?
 
I don't follow what Chromium roll we're talking about here. I can only see 3 regular WebRTC commits in the blame list:
https://chromium.googlesource.com/external/webrtc/+log/0ef8fb91b4930783f0f32cbd3a68e5f98b6ebdd4..8fa21c49eff52b1848ff16483cc3a07af6acc7ca

I know that Android switched from GCC -> Clang in #18537 (https://codereview.webrtc.org/2930243004/) which caused performance changes, but that's far earlier than this.

If we're sure a Clang roll is a perf regression we should probably follow up, yes. First thing would be to look for similar bugs in Chromium though.
Sorry, my bad (clicked the wrong alert in the graph).
You're right, it's a regular Clang roll, and it can affect Android since it's after they switched to use Clang... so if you think the regression is enough to follow up on - file a clang bug or dig into similar Chromium bugs in that range.

Sign in to add a comment