New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733991 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

"Record until full" menu broken

Project Member Reported by maxmorin@chromium.org, Jun 16 2017

Issue description

Chrome Version: 61.0.3128.3 (Official Build) dev (64-bit)
OS: Liunx

What steps will reproduce the problem?
(1) go to chrome:tracing > Record > Edit Categories
(2) Click "Record until full"

What is the expected result?
See other options.

What happens instead?
Dropdown menu just blinks.
 

Comment 1 by grunell@google.com, Jun 16 2017

Same in 59.0.3071.104 Linux.
Cc: benjhayden@chromium.org eakuefner@chromium.org l...@chromium.org charliea@chromium.org
I'm seeing this in 58.0.3029.110 as well.

cc-ing some folks who know tracing ui; anyone have time to take a look?
Owner: benjhayden@chromium.org
Status: Assigned (was: Untriaged)
Confirmed. Looking.
Commenting out the tr.b.timeout in overlay.html fixes it.
Refactoring it to setTimeout does not, so this was not broken by the tr.b.timeout refactor.
Digging for the purpose of that line.
Status: Started (was: Assigned)
https://codereview.chromium.org/2946513002
Fix is on the CQ.

Does the fix need to be merged to a release branch?

Also, who might know whether Chrome's focus behavior changed recently?
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/588c2a7ea03e082bad299146518d35f2aca951e8

commit 588c2a7ea03e082bad299146518d35f2aca951e8
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Sat Jun 17 00:51:20 2017

Roll src/third_party/catapult/ e9dc4c57f..57e600c76 (3 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e9dc4c57fb00..57e600c76c9f

$ git log e9dc4c57f..57e600c76 --date=short --no-merges --format='%ad %ae %s'
2017-06-16 benjhayden Manage focus in overlays.
2017-06-16 rnephew [Telemetry] Allow story expectation names longer than 50 characters if its a url.
2017-06-16 nednguyen Fix style of telemetry/__init__.py

Created with:
  roll-dep src/third_party/catapult
BUG= 733991 ,713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I36965ba9628ee21568d9d7ad1a57d87a39309164
Reviewed-on: https://chromium-review.googlesource.com/539056
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480252}
[modify] https://crrev.com/588c2a7ea03e082bad299146518d35f2aca951e8/DEPS

"Does the fix need to be merged to a release branch?" if this question is directed to me, there's no rush. That said, it's nice to have. Thanks for the quick fix!
Labels: Merge-Request-61
This has been marked ReleaseBlock-Stable in another bug, so requesting merge to 61.
https://bugs.chromium.org/p/chromium/issues/detail?id=752844

I checked that this fix works in ToT on linux and canary on mac.
I cannot imagine how to test this, but I'd be happy to write a test if anybody has a suggestion.
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 9 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls apply appropriate OSs. Thank you.
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
This affects chrome://tracing which is available on all desktop OSs.
Change listed at #7 landed on Jun 17th and we branched M61 on July 20th, so no M61 merge is needed here. Could you please double check?
Labels: -Merge-Review-61
Confirmed no merge is needed here. M61 was branched at Chromium revision: 488528.
Status: Fixed (was: Started)

Sign in to add a comment