New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 733989 link

Starred by 1 user
Status: WontFix
Owner:
msramek@chromium.org
Closed: Jun 2017
Cc:
nyerramilli@chromium.org
kkaluri@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Incognito] Overlapping between focus highlight and ring is seen on 'Learn More' Link.

Reported by db...@etouch.net, Jun 16 2017 
Chrome Version : 61.0.3132.0 407583a866bb1839b09289b5f2e856b15700ea51-refs/heads/master@{#479900}
OS : Mac (10.12.3,10.11.6),Windows(7,8,10),Linux

What steps will reproduce the problem?
(1) Launch chrome, open New incognito window from wrench menu.
(2) Press Tab key upto focus reaches to Learn More link then right click on link or select the link.
(3) Press Esc key to close context menu and observe on Learn More Link.

Actual: Overlapping between focus highlight and ring is seen on Learn More Link.

Expected: No such overlapping should seen.

This is a regression issue, seen from 'M-60' will soon update the other info:

Good Build:60.0.3109.0
Bad Build: 60.0.3110.0
Actual_Video.mov
3.1 MB Download
Actual.png
1.9 MB View Download
Expected.png
2.5 MB View Download

Comment 1 by kkaluri@chromium.org, Jun 16 2017

Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: msramek@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 60.0.3109.0,  Revision Range- 474118
Bad build  : 60.0.3110.0,  Revision Range- 474499

After executing the per-revision-bisect script, i got the following CL's between good and bad build versions
============================================
https://chromium.googlesource.com/chromium/src/+log/dc44616c932d390c6ee11c2eb5931d51e7df91a7..a8852f2672df3b8c9f1daeadbcee5243191de8f5

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/a8852f2672df3b8c9f1daeadbcee5243191de8f5

From the above CL suspecting the below change
--------------------------------------
Review-Url: https://codereview.chromium.org/2902843002

msramek@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.



Thank You...

Comment 2 by msramek@chromium.org, Jun 16 2017

Status: WontFix (was: Assigned)
The focus box follows the border of the element. It used to be larger, because the element was standalone and had a padding. Now that it's a part of the regular text, it can't have a padding.

The highlight, on the other hand, follows the line height which is >1 as per the spec. That's why they overlap.

So this is WAI. I'm not sure why would it be considered a bug in the first place, but please do reopen if I'm missing some UX guidelines.

Comment 3 by benhenry@chromium.org, Sep 29 2017

Components: Blink>HTML>Focus

Comment 4 by benhenry@chromium.org, Sep 29 2017

Components: -Blink>Focus
►

Sign in to add a comment