New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 733888 link

Starred by 1 user
Status: Fixed
Owner:
█ allada@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove NetworkRequest.content, "".contentEncoded and "".contentError.

Project Member Reported by allada@chromium.org, Jun 16 2017 
We need to deprecate these three functions from NetworkRequest in favor of using .requestContent(). Calling the new function should be vary cheap as it should be a cached promise rather than forcing an fetch of data on every call.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8894a5a53943461944899421f1264c33a5a933e

commit b8894a5a53943461944899421f1264c33a5a933e
Author: Nathan Bruer <allada@chromium.org>
Date: Wed Jun 21 09:31:02 2017

[Devtools] Refactor ResponsePreviewView and RequestResponseView

This patch refactors these two views to no long expect
NetworkRequest.content, NetworkRequest.contentEncoded and
NetworkRequest.contentError to exist and rather use
NetworkRequest.contentData() when needed.

R=dgozman,pfeldman
BUG= 733888 

Change-Id: I0ec09c1c1382b1bfd9464837dad2a53ffb05b83b
Reviewed-on: https://chromium-review.googlesource.com/538233
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481157}
[modify] https://crrev.com/b8894a5a53943461944899421f1264c33a5a933e/third_party/WebKit/LayoutTests/http/tests/inspector/network/json-preview.html
[modify] https://crrev.com/b8894a5a53943461944899421f1264c33a5a933e/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html
[modify] https://crrev.com/b8894a5a53943461944899421f1264c33a5a933e/third_party/WebKit/LayoutTests/http/tests/inspector/network/preview-searchable.html
[modify] https://crrev.com/b8894a5a53943461944899421f1264c33a5a933e/third_party/WebKit/Source/devtools/front_end/network/NetworkItemView.js
[modify] https://crrev.com/b8894a5a53943461944899421f1264c33a5a933e/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
[modify] https://crrev.com/b8894a5a53943461944899421f1264c33a5a933e/third_party/WebKit/Source/devtools/front_end/network/RequestResponseView.js
[modify] https://crrev.com/b8894a5a53943461944899421f1264c33a5a933e/third_party/WebKit/Source/devtools/front_end/network/RequestView.js
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d9d6aaf08a2d59da6085329ff4de12315d1a583

commit 2d9d6aaf08a2d59da6085329ff4de12315d1a583
Author: Nathan Bruer <allada@chromium.org>
Date: Wed Jun 21 21:08:38 2017

[Devtools] Removed NetworkRequest.asDataURL()

Removed/Moved asDataURL() to inline and use .contentData() instead of
deprecated properties.

R=dgozman,pfeldman
BUG= 733888 

Change-Id: I3b7e9dfa807b677af24aab555f9252def698d1c4
Reviewed-on: https://chromium-review.googlesource.com/538069
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481296}
[modify] https://crrev.com/2d9d6aaf08a2d59da6085329ff4de12315d1a583/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/2d9d6aaf08a2d59da6085329ff4de12315d1a583/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a27e040de88eea5a9f065a297a8484af5c80a2d5

commit a27e040de88eea5a9f065a297a8484af5c80a2d5
Author: Nathan Bruer <allada@chromium.org>
Date: Wed Jun 21 21:10:46 2017

[Devtools] Moved ExtensionServer away from using deprecated properties

Removes the use of depricated properties .content and .contentEncoded in
SDK.NetworkRequest.

R=dgozman,pfeldman
BUG= 733888 

Change-Id: Ic609753e1338c502227aff94d4b36238934fa348
Reviewed-on: https://chromium-review.googlesource.com/538875
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481300}
[modify] https://crrev.com/a27e040de88eea5a9f065a297a8484af5c80a2d5/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91ecb9e41fcb5ae18e059bdaff4469244bbebb12

commit 91ecb9e41fcb5ae18e059bdaff4469244bbebb12
Author: Nathan Bruer <allada@chromium.org>
Date: Fri Jun 30 00:16:41 2017

[Devtools] Final removal of .content & .contentEncoded NetworkRequest

This is the final in a series to remove the deprecated content request
properties in SDK.NetworkRequest.

R=dgozman,pfeldman
BUG= 733888 

Change-Id: Iedf04be8dd293c1592e903a440b2cb0db1c226e4
Reviewed-on: https://chromium-review.googlesource.com/538978
Reviewed-by: Blaise Bruer <allada@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483557}
[modify] https://crrev.com/91ecb9e41fcb5ae18e059bdaff4469244bbebb12/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Comment 5 by allada@chromium.org, Jul 11 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment