New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733886 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

middle mouse pasting URLs onto omnibox search icon no longer navigates to URL

Project Member Reported by vapier@chromium.org, Jun 16 2017

Issue description

Chrome Version: 61.0.3128.3
OS Version: Linux (KDE)

What steps will reproduce the problem?
1. copy a url like http://example.com with mouse
2. open a new tab
3. middle mouse paste over the search icon in the omnibox
4. when nothing happens, middle mouse paste into the omnibox directly and see URL come up (and then hit enter to navigate manually)

What is the expected result?
the omnibox should have accepted the URL and navigated automatically.  Chrome used to behave this way.

it works if you visit a secure site and then middle mouse paste onto the secure icon chip.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3128.3 Safari/537.36
 

Comment 1 by k...@chromium.org, Jun 16 2017

Status: Available (was: Unconfirmed)
Confirmed: Pasting on secure chip or (i) information icon works; magnifying glass does not. Worked in 59, for example.
Labels: -Pri-2 Pri-3
Labels: Needs-Bisect
Adding Needs-Bisect to see if someone can tell us when this regression happened.
Cc: msrchandra@chromium.org
Components: IO>Mouse
Labels: -Pri-3 -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable M-60 OS-Mac OS-Windows Pri-2
Owner: spqc...@chromium.org
Status: Assigned (was: Available)
Able to reproduce the issue on Latest Dev# 61.0.3141.7, Latest Beta# 60.0.3112.50 on Windows, Mac and Linux.
This is a Regression issue in M60 builds. Below is the regression info --
Chrome Good Build -- 60.0.3107.0 (473482).
Chrome Bad  Build -- 60.0.3108.0 (473773).
You are probably looking for a change made after 473646 (known good), but no later than 473647 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/1a25f28b9fbf2ec51a542202b9c0576723f3932b..bf7e0532e34476062226eab6ef1affe78abc8a8d

Review URL --
https://codereview.chromium.org/2720183002

@spqchan -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Adding RB Label as this is a recent Regression. Please remove if not needed.
Thank You.

Cc: rbasuvula@chromium.org
Friendly Ping! Still able to reproduce the issue on Ubuntu 14.04 using latest chrome version 61.0.3147.0.

@spqchan Could you please look into this issue as it has been marked as a stable blocker..

Thanks!
@spqchan : Gentle Ping! Could you please update on this issue.

Thank You!
Just to update,
Still able to reproduce the issue on Win-10 using latest canary #61.0.3159.0.

spqchan@ - Gentle Ping...!!
Could you please have a look into the issue as it has been marked as a stable blocker.

Thanks...!!
Labels: -M-60 M-61
This isn't high enough severity for a fix getting merged into M60 at this point.  Moving to M61.

Comment 9 by gov...@chromium.org, Jul 26 2017

URGENT - PTAL.
Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the M61 branch #3163 ASAP to have enough baking time in Beta before Stable promotion. Thank you!

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.

Issue is still reproducible using #62.0.7171.0 on Mac 10.12.5.

@spqchan: Is there any latest updates available on this issue?

Thanks!!
Investigating this
Cc: ranjitkan@chromium.org
@ spqchan: Gentle ping, request you to please provide an update on it as issue is tagged with a Stable blocker and targeted to M61. 
Labels: -M-61 M-62
I'm still looking into this. I'm pushing this to M62 because it's not a high enough priority to merge into Beta. Let me know if otherwise
Labels: -OS-Windows -OS-Mac
Your bug is tagged as Release block Stable. 

M62 is branching soon and We will be taking only CRITICAL merges. Please plan accordingly.
spqchan@,

Friendly ping!!
Still we are able to reproduce the issue on windows 7,mac 10.12.6 & ubuntu 14.04 using stable#60.0.3112.113,Dev#62.0.3192.0 & Canary#62.0.3198.0.
Could you please take a look and update the thread accordingly.
Thanks..!
As it is a stable blocker issue , please take a look ASAP.

Thanks.
Gentle ping to get an update on this issue as it is a stable blocker.

Thanks..!!
Just to update the latest behavior, this issue is still reproducible on chrome latest dev #63.0.3212.0.

spqchan@ Since this issue is marked as RB-Stable can you please let us know is there any latest update available on this issue?

Thanks!
spqchan@ Ping! Since this issue is marked as RB-Stable can we get any latest update on this issue?

Thanks!
Looking into it, I have an idea why it's not working
Status: Started (was: Assigned)
Fix WIP: https://chromium-review.googlesource.com/c/chromium/src/+/691428
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d15c77dedd4725f6ac4ec2af51826b419d8bfe2

commit 8d15c77dedd4725f6ac4ec2af51826b419d8bfe2
Author: spqchan <spqchan@chromium.org>
Date: Wed Oct 04 05:22:17 2017

[Views] Fix Search Icon Middle Mouse Pasting

The location icon was disabled when the omnibox is
empty or emptying. This was to prevent the search
icon from being highlighted when the user hovers
over it. However, this disables middle mouse pasting.

To fix this issue, instead of enabling/disabling the
the location icon, the ink drop mode will be turned
on/off.

Getting the InkDropMode is added to
InkDropHostViewTestApi for testing.

Testing: LocationIconViewBrowserTest

Bug:  733886 
Change-Id: Iefc1d0d41dec25634e4eef5785ef2115a5c5496f
Reviewed-on: https://chromium-review.googlesource.com/691428
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506309}
[modify] https://crrev.com/8d15c77dedd4725f6ac4ec2af51826b419d8bfe2/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/8d15c77dedd4725f6ac4ec2af51826b419d8bfe2/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/8d15c77dedd4725f6ac4ec2af51826b419d8bfe2/chrome/browser/ui/views/location_bar/location_icon_view.h
[add] https://crrev.com/8d15c77dedd4725f6ac4ec2af51826b419d8bfe2/chrome/browser/ui/views/location_bar/location_icon_view_browsertest.cc
[modify] https://crrev.com/8d15c77dedd4725f6ac4ec2af51826b419d8bfe2/chrome/test/BUILD.gn
[modify] https://crrev.com/8d15c77dedd4725f6ac4ec2af51826b419d8bfe2/ui/views/animation/test/ink_drop_host_view_test_api.h

spqchan@, thank you for the fix. Can you please request a merge to M62 if required?
Labels: Merge-Request-62
Project Member

Comment 26 by sheriffbot@chromium.org, Oct 6 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks spqchan@ - can you please confirm if you've tested this fix in Canary and if it's a safe merge overall?
Tested this issue on Ubuntu 14.04 using chrome latest dev #63.0.3236.0 by following steps mentioned in the original comment. By middle mouse paste over the search icon in the omnibox observed the page is not navigated automatically until press enter manually from keyboard. 

spqchan@ Is this issue fixed completely? Could you please confirm how to verify this issue from chrome-TE end? Please correct me if anything missing from my end.

Thanks!
That is strange, it should navigate immediately.
Let me have a look. Since we're only 7 days from stable, perhaps we should push this to M63 since I  don't think the issue is serious enough to be a release blocer
Labels: -M-62 M-63
Changing Milestone to M63 as per c#29.
Cc: abdulsyed@chromium.org
Labels: -Merge-Review-62 Merge-Rejected-62
Rejecting merge to M62 per comment #29 and this has been exists since M60.
I'm unable to reproduce what was described in #62. It works for me and navigates automatically
Status: Fixed (was: Started)
Closing this as fixed since it works fine for me on dev. Please reopen if otherwise

Sign in to add a comment