New issue
Advanced search Search tips

Issue 733883 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

TypeError thrown on RunCommand kill -9 in cros_vm

Project Member Reported by achuith@chromium.org, Jun 16 2017

Issue description

We get an error like:
Exception TypeError: TypeError('signal handler must be signal.SIG_IGN, signal.SIG_DFL, or a callable object',) in <bound method VMTest.__del__ of <chromite.scripts.cros_run_vm_test.VMTest object at 0x7fd5ac72f510>> ignored

This is thrown by RunCommand here:
https://cs.corp.google.com/chromeos_public/chromite/scripts/cros_vm.py?l=202

I only see this when I run cros_run_vm_test --disable-kvm

RunCommand does some funky signal handling, and maybe there's a bug in there somewhere.
 

Comment 1 by vapier@chromium.org, Jun 16 2017

would be nice to get the full traceback instead of the stripped down so we know which signal call is failing.  doesn't --debug do that ?
Cc: steve...@chromium.org
Mike, I wasn't able to get a traceback - I think this is because this failure is happening on exit in the __del__ function. I used debug_level=logging.DEBUG but got no new info, and tried some printf debugging. 

Anyway I have a fix that seems to be ok: https://chromium-review.googlesource.com/c/538059/

Comment 3 by vapier@chromium.org, Jun 17 2017

for printing, try writing directly.  something like:

 print('...', file=open('/dev/tty', 'w'))
Status: Fixed (was: Assigned)

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment