New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733877 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

deploy_chrome failure with non-internal chromium

Project Member Reported by achuith@chromium.org, Jun 16 2017

Issue description

deploy_chrome fails with non-internal chromium on a widevine dependency.

Dirk, if you have the logs handy, could you please add them here? Otherwise I can try to reproduce this failure.
 
I've attached the log from running:

% cros chrome-sdk --board amd64-generic --download-vm --internal --version 9592.0.0 -- cros_run_vm_test --deploy --build-dir out_amd64-generic/Release 2>&1 | tee log
At first glance, this doesn't look like an infrastructure problem. (wrong component).

I'm not even convinced that this is a tooling problem. Is the dependency just missing from external chromium (need to find who added that dependency) or is the tooling looking for it in the wrong place (no clear owner for tooling, but I can help find one).
Components: -Infra>Client>ChromeOS OS>Kernel>Video Build
Looks like a fallout of / related to: https://bugs.chromium.org/p/chromium/issues/detail?id=612248

stevenjb@ (already CC'ed) would know best.
Moving to the same components.
@pprabhu - I'm not 100% sure I understand enough about how the cros builds work, but my understanding is that widevine should *not* be required or even present on external (public) builds. So, I think we need to make sure there's no dependency needed?

Comment 5 by rcui@chromium.org, Jun 20 2017

Cc: -rcui@chromium.org achuith@chromium.org
Owner: rcui@chromium.org
Taking this from Achuith as he's got some other stuff going on.

Comment 6 by rcui@chromium.org, Jun 20 2017

The error looks to be the result of running 'cros chrome-sdk' with the '--internal' flag.  The error does not occur when running without '--internal'.

Comment 7 by rcui@chromium.org, Jun 21 2017

Status: WontFix (was: Untriaged)
'--internal' sets certain GN flags which causes deploy_chrome to treat the build as an internal build which has widevine enabled.  Closing as this is working as intended.
Dirk - can you confirm that not using --internal in cros chrome-sdk works? Is there a reason to use it?

Sign in to add a comment