deploy_chrome failure with non-internal chromium |
||||
Issue descriptiondeploy_chrome fails with non-internal chromium on a widevine dependency. Dirk, if you have the logs handy, could you please add them here? Otherwise I can try to reproduce this failure.
,
Jun 16 2017
At first glance, this doesn't look like an infrastructure problem. (wrong component). I'm not even convinced that this is a tooling problem. Is the dependency just missing from external chromium (need to find who added that dependency) or is the tooling looking for it in the wrong place (no clear owner for tooling, but I can help find one).
,
Jun 16 2017
Looks like a fallout of / related to: https://bugs.chromium.org/p/chromium/issues/detail?id=612248 stevenjb@ (already CC'ed) would know best. Moving to the same components.
,
Jun 16 2017
@pprabhu - I'm not 100% sure I understand enough about how the cros builds work, but my understanding is that widevine should *not* be required or even present on external (public) builds. So, I think we need to make sure there's no dependency needed?
,
Jun 20 2017
Taking this from Achuith as he's got some other stuff going on.
,
Jun 20 2017
The error looks to be the result of running 'cros chrome-sdk' with the '--internal' flag. The error does not occur when running without '--internal'.
,
Jun 21 2017
'--internal' sets certain GN flags which causes deploy_chrome to treat the build as an internal build which has widevine enabled. Closing as this is working as intended.
,
Jun 21 2017
Dirk - can you confirm that not using --internal in cros chrome-sdk works? Is there a reason to use it? |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Jun 16 201714.8 KB
14.8 KB View Download