Potential refactoring bug in content_view_core_impl |
||
Issue descriptionDuring the refactor here: https://codereview.chromium.org/2785853002 It looks like ContentViewCoreImpl::ShowContextMenu() had an if check that went from: !(params.is_editable && params.selection_text.empty()) to (!params.is_editable && params.selection_text.empty()) The "!" got moved inside the parenthesis. Just want to check that this was intentional and if not get it assigned. Thanks!
,
Jun 16 2017
The move was intentional. We don't want to show the menu when it is not editable and isn't a selection. Thanks for being on the lookout!
,
Jun 16 2017
Ok thanks! Investigating another M59 bug and tracking context menu image download changes. Sorry for the false alarm! |
||
►
Sign in to add a comment |
||
Comment 1 by dtrainor@chromium.org
, Jun 15 2017