New issue
Advanced search Search tips

Issue 733858 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make functions static inside cups/util.c

Project Member Reported by xiaochu@chromium.org, Jun 15 2017

Issue description

Following (introduced in https://chromium-review.googlesource.com/c/518931/) should be static: 

match_filter
nftw_mut
checkVersion
parseVersion
compareVersion

 
Components: Internals>Printing>CUPS
Owner: xiaochu@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/455dcb7ff979d68774aafeb01c15d3958039e2f6

commit 455dcb7ff979d68774aafeb01c15d3958039e2f6
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Thu Sep 28 06:52:15 2017

cups: make internal helper functions static

No new code. Only change the declaration of functions to be static.

BUG= chromium:733858 
TEST=compilation passed

Change-Id: Ie72f83aca08c82ade675de05dfefe042272d927e
Reviewed-on: https://chromium-review.googlesource.com/665579
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[rename] https://crrev.com/455dcb7ff979d68774aafeb01c15d3958039e2f6/net-print/cups/cups-2.1.4-r26.ebuild
[modify] https://crrev.com/455dcb7ff979d68774aafeb01c15d3958039e2f6/net-print/cups/files/cups-2.1.4-search-filter.patch

Status: Fixed (was: Started)

Sign in to add a comment