So, the problem is that the initialization of the connection info popup goes something like this:

- ConnectionInfoPopup() constructor (Java)
- nativeInit() -> Init() (C++)
- ConnectionInfoPopupAndroid() (C++)
- get security info, construct PageInfo, PresentSiteIdentity, etc.
- addResetCertDecisionsButton() (Java)

Now, mNativeConnectionInfoPopup will not have a value until nativeInit() in the constructor returns – but we're still doing work for nativeInit()!

This has been around since the introduction of ConnectionInfoPopup.java:
https://codereview.chromium.org/1100283002
The code came refactored – but mostly wholesale from https://chromium.googlesource.com/chromium/src/+/64c23723b3f3b67d0aab3e605645ae434f6affad/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopupLegacy.java
I'm guessing at some point the connection info was not sent to the Java code until the main object was constructed?

Given that the code has been functioning on non-debug builds for a long time, my conclusion here is that we should just take out the assert. It's a bit sad that no one ever wrote tests or tried to open connection info after clicking through an interstitial on a build with debug checks.

I can't figure out how to get an old Clank checkout (`gclient sync` seems to always update `src` and `src/clank` to today), so I'm just going to send a CL to remove the assert.

I'm trying to add a test to exercise that code path: https://codereview.chromium.org/2948453002

However, I'm having trouble calling ConnectionInfoPopup.show() (which calls the private constructor).

org.chromium.chrome.browser.page_info.ConnectionInfoPopupTest.showConnectionInfoPopup
java.lang.NullPointerException
	at org.robolectric.shadows.ShadowViewConfiguration.setup(ShadowViewConfiguration.java:77)
	at org.robolectric.shadows.ShadowViewConfiguration.get(ShadowViewConfiguration.java:94)
	at android.view.ViewConfiguration.get(ViewConfiguration.java)
	at android.view.View.__constructor__(View.java:4026)
	at android.view.View.<init>(View.java)
	at android.view.ViewGroup.<init>(ViewGroup.java)
	at android.widget.LinearLayout.<init>(LinearLayout.java)
	at org.chromium.chrome.browser.page_info.ConnectionInfoPopup.<init>(ConnectionInfoPopup.java:57)
	at org.chromium.chrome.browser.page_info.ConnectionInfoPopup.show(ConnectionInfoPopup.java:242)
	at org.chromium.chrome.browser.page_info.ConnectionInfoPopupTest.showConnectionInfoPopup(ConnectionInfoPopupTest.java:36)

Carlos, Chris, am I remembering correctly that one of you fixed this at some point?

Yep, looks like this is the same as  Issue 825911 . Duping into that one since it was where the fix CL pointed.