Remove ``StacktraceParser`` interface. |
||
Issue descriptionThe ``StacktraceParser`` interface no longer serves any purpose, as no code in Predator works with this interface, only with specific subclasses of it. It can safely be removed.
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b075b96a487f84a2d9b87a67af4ff5ab4ef336ac commit b075b96a487f84a2d9b87a67af4ff5ab4ef336ac Author: Cathal Weakliam <cweakliam@google.com> Date: Wed Jun 21 19:25:19 2017 Remove StacktraceParser interface. This interface no longer serves any purpose, as no code in Predator works with it, only with specific subclasses of it. Also its only non-abstract method, ``FilterStackBuffer``, is not executed anywhere except tests. Its functionality is duplicated elsewhere, in the ``Stacktrace.AddFilteredStack`` method. R=katesonia@google.com Bug: 733854 Change-Id: I3f845de1b936c26db65ab1d1826f826f69f1f992 Reviewed-on: https://chromium-review.googlesource.com/538868 Commit-Queue: Cathal Weakliam <cweakliam@google.com> Reviewed-by: Sharu Jiang <katesonia@chromium.org> [delete] https://crrev.com/58d03699896f4c7935422422a651a8dbad172b61/appengine/predator/analysis/stacktrace_parser.py [modify] https://crrev.com/b075b96a487f84a2d9b87a67af4ff5ab4ef336ac/appengine/predator/analysis/chromecrash_parser.py [modify] https://crrev.com/b075b96a487f84a2d9b87a67af4ff5ab4ef336ac/appengine/predator/analysis/clusterfuzz_parser.py [delete] https://crrev.com/58d03699896f4c7935422422a651a8dbad172b61/appengine/predator/analysis/test/stacktrace_parser_test.py [modify] https://crrev.com/b075b96a487f84a2d9b87a67af4ff5ab4ef336ac/appengine/predator/analysis/uma_sampling_profiler_parser.py
,
Jun 26 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by cweakliam@google.com
, Jun 16 2017