New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733852 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Callbacks of onWrite should report how many pages we actually wrote to file instead of PageRange.ALL_PAGES

Project Member Reported by ctzsm@chromium.org, Jun 15 2017

Issue description

Report PageRange.ALL_PAGES to callbacks in onWrite is not the correct behavior that the framework is expecting, we need to pass actual page numbers to it instead.
 

Comment 1 by ctzsm@chromium.org, Jun 15 2017

Components: Internals>Printing

Comment 2 by ctzsm@chromium.org, Jun 15 2017

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b414956dd71a62ba04a0bc80ce259b6bcbaceed8

commit b414956dd71a62ba04a0bc80ce259b6bcbaceed8
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Fri Jun 30 02:41:23 2017

[Android] Report correct printing PageRange to onWrite* callbacks

Currently we report onWrite* callbacks PageRange from what we get
from `onWrite`. However, It will give PageRange.ALL_PAGES when
printing all pages. This behavior is fine for now but will not
be accepted in future.

This CL changed the behavior to report how many pages we need
to print if print all pages.

Bug:  733852 
Change-Id: Iff1fe57baf1989910f0c29329b42bfbf26c86e05
Reviewed-on: https://chromium-review.googlesource.com/551278
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483597}
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/android_webview/browser/aw_pdf_exporter.cc
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/android_webview/browser/aw_pdf_exporter.h
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/android_webview/browser/aw_printing_message_filter.cc
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/android_webview/browser/aw_printing_message_filter.h
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/android_webview/java/src/org/chromium/android_webview/AwPdfExporter.java
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/android_webview/java/src/org/chromium/android_webview/AwPrintDocumentAdapter.java
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/chrome/browser/printing/printing_message_filter.cc
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/chrome/browser/printing/printing_message_filter.h
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/components/printing/browser/print_manager.cc
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/components/printing/browser/print_manager.h
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/components/printing/common/print_messages.h
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/components/printing/renderer/print_web_view_helper_linux.cc
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/printing/android/java/src/org/chromium/printing/PrintingContext.java
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/printing/android/java/src/org/chromium/printing/PrintingController.java
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/printing/android/java/src/org/chromium/printing/PrintingControllerImpl.java
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/printing/printing_context_android.cc
[modify] https://crrev.com/b414956dd71a62ba04a0bc80ce259b6bcbaceed8/printing/printing_context_android.h

Comment 4 by ctzsm@chromium.org, Jul 5 2017

Status: Fixed (was: Assigned)

Sign in to add a comment