New issue
Advanced search Search tips

Issue 733846 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 731133



Sign in to add a comment

Expose USB and display info in feedbackPrivate.readLogSource

Project Member Reported by sque@chromium.org, Jun 15 2017

Issue description

Previously, a new API function to get log info from a single log source was added: https://codereview.chromium.org/2840103002/

I'd like to extend this to get info about USB (both device IDs and connectivity) and displays (connector type, model, manufacturer).

This is required by http://go/project-kondo.
 

Comment 1 by sque@chromium.org, Jun 21 2017

Summary: Expose USB and display info in feedbackPrivate.readLogSource (was: Expose USB and display info in feedbackPrivate.getSystemInformation)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dea6441d2d8033ee73d5f746c34be09c03ed4758

commit dea6441d2d8033ee73d5f746c34be09c03ed4758
Author: sque <sque@chromium.org>
Date: Mon Jul 10 15:57:30 2017

Rename SingleLogSource to SingleLogFileLogSource

Since there is now a class SingleDebugDaemonLogSource, the old
name "SingleLogSource" is ambiguous. Rename it to indicate that the
logs come from a log file.

Also refactored the use of SingleLogSource in feedbackPrivate API:
- Use the base interface class SystemLogsSource instead, in
  LogSourceAccessManager.
- Convert from feedback_private::LogSource directly to a
  SystemLogSource in SingleLogSourceFactory. Conversion of enums is
  internal to SingleLogSourceFactory.

BUG= 733846 

Review-Url: https://codereview.chromium.org/2956513004
Cr-Commit-Position: refs/heads/master@{#485283}

[modify] https://crrev.com/dea6441d2d8033ee73d5f746c34be09c03ed4758/chrome/browser/chromeos/BUILD.gn
[rename] https://crrev.com/dea6441d2d8033ee73d5f746c34be09c03ed4758/chrome/browser/chromeos/system_logs/single_log_file_log_source.cc
[rename] https://crrev.com/dea6441d2d8033ee73d5f746c34be09c03ed4758/chrome/browser/chromeos/system_logs/single_log_file_log_source.h
[rename] https://crrev.com/dea6441d2d8033ee73d5f746c34be09c03ed4758/chrome/browser/chromeos/system_logs/single_log_file_log_source_unittest.cc
[modify] https://crrev.com/dea6441d2d8033ee73d5f746c34be09c03ed4758/chrome/browser/extensions/api/feedback_private/feedback_private_api_chromeos_unittest.cc
[modify] https://crrev.com/dea6441d2d8033ee73d5f746c34be09c03ed4758/chrome/browser/extensions/api/feedback_private/log_source_access_manager.cc
[modify] https://crrev.com/dea6441d2d8033ee73d5f746c34be09c03ed4758/chrome/browser/extensions/api/feedback_private/log_source_access_manager_chromeos_unittest.cc
[modify] https://crrev.com/dea6441d2d8033ee73d5f746c34be09c03ed4758/chrome/browser/extensions/api/feedback_private/log_source_resource.cc
[modify] https://crrev.com/dea6441d2d8033ee73d5f746c34be09c03ed4758/chrome/browser/extensions/api/feedback_private/log_source_resource.h
[modify] https://crrev.com/dea6441d2d8033ee73d5f746c34be09c03ed4758/chrome/browser/extensions/api/feedback_private/single_log_source_factory.cc
[modify] https://crrev.com/dea6441d2d8033ee73d5f746c34be09c03ed4758/chrome/browser/extensions/api/feedback_private/single_log_source_factory.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a135bf808de1da0ae1198d63b0f1901e42596c4f

commit a135bf808de1da0ae1198d63b0f1901e42596c4f
Author: sque <sque@chromium.org>
Date: Tue Jul 11 22:35:18 2017

Add SingleDebugDaemonLogSources to feedbackPrivate.readLogSource()

The two supported log sources are:
- modetest
- lsusb

BUG= 733846 

Review-Url: https://codereview.chromium.org/2956623003
Cr-Commit-Position: refs/heads/master@{#485710}

[modify] https://crrev.com/a135bf808de1da0ae1198d63b0f1901e42596c4f/chrome/browser/extensions/api/feedback_private/single_log_source_factory.cc
[modify] https://crrev.com/a135bf808de1da0ae1198d63b0f1901e42596c4f/chrome/common/extensions/api/feedback_private.idl

sque: Is it easy to expose "lscpi -n" the same way? Will adding another switch make things break? Alternatively making "lspci -nn" the default would work too.

Comment 6 by sque@chromium.org, Jul 14 2017

Yes, it should be straightforward. Things to be done:
1. Add the "lspci -n" to src/platform2/debugd/src/log_tool.cc
2. Add it as a supported type to SingleDebugDaemonLogSource.
2. Add it to the feedbackPrivate.readLogSource API function.

Comment 7 by sque@chromium.org, Sep 22 2017

Status: Fixed (was: Assigned)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment