New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733840 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

sponge and result_utils errors

Project Member Reported by ihf@chromium.org, Jun 15 2017

Issue description

From  issue 733738 .
One thing I notice is that a bunch of result collection is going wrong. Test did fail though due to some sort of hang. Still looking for that.

https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/123265055-chromeos-test/chromeos2-row8-rack6-host11/

ERROR:root:Failed to upload to sponge.
Traceback (most recent call last):
  File "/usr/local/autotest/site_utils/sponge_lib/sponge_utils.py", line 53, in upload_results
    return upload_utils.UploadInfo(info)
  File "/usr/local/autotest/site-packages/sponge/upload_utils.py", line 40, in UploadInfo
    invocation = formatter.format_data(info)
  File "/usr/local/autotest/site-packages/sponge/sponge_formatter.py", line 188, in format_data
    generate_and_format_child_tests(test_result_info)
  File "/usr/local/autotest/site-packages/sponge/sponge_formatter.py", line 184, in generate_and_format_child_tests
    child_formatter.format_test_result(child_test_result_info)
  File "/usr/local/autotest/site-packages/sponge/common_formatters.py", line 51, in format_test_result
    self._invoke_on_all('format_test_result', info)
  File "/usr/local/autotest/site-packages/sponge/common_formatters.py", line 23, in _invoke_on_all
    getattr(inner, func_name)(*args, **kwargs)
  File "/usr/local/autotest/site-packages/sponge/chromeos_sponge_formatters.py", line 90, in format_test_result
    end_time = long(test.end_time * 1000.0)
TypeError: unsupported operand type(s) for *: 'NoneType' and 'float'
tko parser: Failed to upload to sponge.
Traceback (most recent call last):
  File "/usr/local/autotest/site_utils/sponge_lib/sponge_utils.py", line 53, in upload_results
    return upload_utils.UploadInfo(info)
  File "/usr/local/autotest/site-packages/sponge/upload_utils.py", line 40, in UploadInfo
    invocation = formatter.format_data(info)
  File "/usr/local/autotest/site-packages/sponge/sponge_formatter.py", line 188, in format_data
    generate_and_format_child_tests(test_result_info)
  File "/usr/local/autotest/site-packages/sponge/sponge_formatter.py", line 184, in generate_and_format_child_tests
    child_formatter.format_test_result(child_test_result_info)
  File "/usr/local/autotest/site-packages/sponge/common_formatters.py", line 51, in format_test_result
    self._invoke_on_all('format_test_result', info)
  File "/usr/local/autotest/site-packages/sponge/common_formatters.py", line 23, in _invoke_on_all
    getattr(inner, func_name)(*args, **kwargs)
  File "/usr/local/autotest/site-packages/sponge/chromeos_sponge_formatters.py", line 90, in format_test_result
    end_time = long(test.end_time * 1000.0)
TypeError: unsupported operand type(s) for *: 'NoneType' and 'float'
tko parser: Failed to calculate result sizes based on directory summaries. Fall back to record the total size.
Exception: Traceback (most recent call last):
  File "/usr/local/autotest/tko/parse.py", line 276, in _get_result_sizes
    client_collected_bytes, summary = result_utils.merge_summaries(path)
  File "/usr/local/autotest/client/bin/result_utils.py", line 345, in merge_summaries
    client_collected_bytes = merged_summary[ROOT_DIR][COLLECTED_SIZE_BYTES]
KeyError: ''

tko parser: * testname, status, reason: ---- ABORT 
tko parser: * testname, status, reason: cheets_StartAndroid.stress ABORT None
tko parser: * testname, status, reason: cheets_StartAndroid.stress ABORT None
 

Comment 1 by dshi@chromium.org, Jun 15 2017

Owner: bpeake@chromium.org
Benny, please fix the sponge error:
TypeError: unsupported operand type(s) for *: 'NoneType' and 'float'
tko parser: Failed to upload to sponge.
Traceback (most recent call last):
  File "/usr/local/autotest/site_utils/sponge_lib/sponge_utils.py", line 53, in upload_results
    return upload_utils.UploadInfo(info)
  File "/usr/local/autotest/site-packages/sponge/upload_utils.py", line 40, in UploadInfo
    invocation = formatter.format_data(info)
  File "/usr/local/autotest/site-packages/sponge/sponge_formatter.py", line 188, in format_data
    generate_and_format_child_tests(test_result_info)
  File "/usr/local/autotest/site-packages/sponge/sponge_formatter.py", line 184, in generate_and_format_child_tests
    child_formatter.format_test_result(child_test_result_info)
  File "/usr/local/autotest/site-packages/sponge/common_formatters.py", line 51, in format_test_result
    self._invoke_on_all('format_test_result', info)
  File "/usr/local/autotest/site-packages/sponge/common_formatters.py", line 23, in _invoke_on_all
    getattr(inner, func_name)(*args, **kwargs)
  File "/usr/local/autotest/site-packages/sponge/chromeos_sponge_formatters.py", line 90, in format_test_result
    end_time = long(test.end_time * 1000.0)
TypeError: unsupported operand type(s) for *: 'NoneType' and 'float'

For the last KeyError, I will have a fix for that.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0f37b06e544c2bec817ebc4370b60155646d462f

commit 0f37b06e544c2bec817ebc4370b60155646d462f
Author: Dan Shi <dshi@google.com>
Date: Fri Jun 16 06:54:00 2017

[autotest] Handle the case where no directory summary was collected.

BUG= chromium:733840 
TEST=local run parse job

Change-Id: I99fffc0548f2f07c1bb3b0016ca1a524f327a5a7
Reviewed-on: https://chromium-review.googlesource.com/538116
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Dan Shi <dshi@google.com>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/0f37b06e544c2bec817ebc4370b60155646d462f/client/bin/result_utils_unittest.py
[modify] https://crrev.com/0f37b06e544c2bec817ebc4370b60155646d462f/client/bin/result_utils.py

Labels: -Pri-3 Pri-2
Status: Assigned (was: Untriaged)
iiuc, this means that sponge results aren't being uploaded under certain conditions right now?
This is a degradation to a Class 2 infra service, so Pri 2.

The only AI left is on bpeake@, so assigned.

Comment 4 by dshi@chromium.org, Jun 16 2017

Status: Fixed (was: Assigned)
Sponge issue is fixed here:
https://chrome-internal-review.googlesource.com/#/c/376468/

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment