New issue
Advanced search Search tips

Issue 733822 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

run_blink_httpd.py only serves from out/Release

Project Member Reported by reillyg@chromium.org, Jun 15 2017

Issue description

The script third_party/WebKit/Tools/Scripts/run-blink-httpd does not support the same platform and build configuration options as run-webkit-tests, including the ability to specify the build output directory from which to serve files. It will only serve files from out/Release.
 
As far as I understand, run-blink-httpd serves files from //third_party/WebKit/LayoutTests/http/tests/, not from out/Release.

Also, I believe that run-blink-httpd doesn't depend on any build products in Chromium - it starts system apache to serve files from the layout tests directory.

But maybe I'm mistaken -- could you clarify and provide an example so I could understand better?
Layout tests which use Mojo's JavaScript bindings depend on build artifacts. I'm about to patch the service configuration to include these generated sources in the resources served by the server.

It also appears that we currently alias the generated inspector sources into /inspector-sources.
Cc: qyears...@chromium.org
Status: Available (was: Untriaged)
Finally going back to triage this --

The build directory used for /inspector-sources is determined by Port.inspector_build_directory (https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py?l=1032). The specific directory there can be determined by the --target option (e.g. --target Default or --target Debug). However, run-blink-httpd and the other run-blink- scripts don't accept a --target option.

We could add a --target option to webkitpy/layout_tests/servers/cli_wrapper.py and use it, which would allow serving from other build directories.
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 13

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Summary: run_blink_httpd.py only serves from out/Release (was: run-blink-httpd only serves from out/Release)

Sign in to add a comment