Issue metadata
Sign in to add a comment
|
California doesn't match to CA in the Payment Request editor on Android |
||||||||||||||||||||
Issue descriptionSteps: 1) Create an Autofill profile in the settings with the state "California" in Country being the US 2) go to https://rsolomakhin.github.io/pr/single/ and click buy 3) edit the profile Expected: The state is selected as CA Actual: AA is selected instead
,
Jun 15 2017
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79db73ddd4456ed457211439708ba7e0cd120832 commit 79db73ddd4456ed457211439708ba7e0cd120832 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Fri Jun 16 16:01:10 2017 Don't clobber user's state/province in PaymentRequest address editor. Before this patch, editing a shipping address with "California" state in PaymentRequest UI on Android would result in "AA" selected in the state dropdown. This is frustrating to the user and could result in delivery errors on merchant side. The reason for this behavior is absence of California-to-CA mapping logic, which prevents "CA" state from being selected in the dropdown. This patch checks whether the dropdown values list contains the state of the shipping address. If there's no match, then the address editor uses a text field for state instead of a dropdown. This is the same fallback strategy that's used for the case of failure to download the list of states/provinces for a country. After this patch, editing a shipping address with "California" state results in a text field being used for the state field. This text field would contain the text "California". Bug: 733803 Change-Id: Icac00bf8e564f2f7aaad5e64e3208dc50231d64b Reviewed-on: https://chromium-review.googlesource.com/538593 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#480060} [modify] https://crrev.com/79db73ddd4456ed457211439708ba7e0cd120832/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
,
Jun 16 2017
Hello, I would like to merge this fix into M-60 to avoid a regression in Android UI of Paymentrequest.
,
Jun 16 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 20 2017
Merge approved for M60 branch 3112.
,
Jun 20 2017
Landed as: https://chromium.googlesource.com/chromium/src/+/b4446c54cdbcaf32e3575bd0f8d8e01fdace28ad
,
Jun 20 2017
,
Jun 22 2017
Verified in M60-60.0.3112.43 build. N device -> When enter California in Autofill-Payment editor displayed CA KTU84P device->When enter California in Autofill-Payment editor displayed California Screenshots @ http://go/chrome-androidlogs1/7/733803
,
Jun 27 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by rouslan@chromium.org
, Jun 15 2017