Issue metadata
Sign in to add a comment
|
Mark-Nonsecure-As missing from chrome://flags on iOS |
||||||||||||||||||||||||
Issue descriptionChrome Version: 61.3028 What steps will reproduce the problem? (1) Visit chrome://flags/#mark-non-secure-as What is the expected result? Mark-Non-Secure-As setting is present. What happens instead? It's missing.
,
Jun 15 2017
iOS gets its flags from //src/ios/chrome/browser/about_flags.mm and ignores //src/chrome/browser/about_flags.cc
,
Jun 15 2017
The CL that brought the settings in for other platforms is referenced in Issue 721896 .
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/816f6790e1d58d4e25d224755fc6d3fa2cd887e7 commit 816f6790e1d58d4e25d224755fc6d3fa2cd887e7 Author: elawrence <elawrence@chromium.org> Date: Fri Jun 16 18:19:28 2017 Add new mark-non-secure-as options to chrome://flags on iOS We recently added new options for the MarkHttpAs setting. iOS does not use about_flags.cc, instead specifying flags in about_flags.mm. This CL adds the new MarkHttpAs flag settings to the iOS-specific file. BUG= 733800 TEST=Navigate to chrome://flags/#mark-non-secure-as Review-Url: https://codereview.chromium.org/2938273002 Cr-Commit-Position: refs/heads/master@{#480102} [modify] https://crrev.com/816f6790e1d58d4e25d224755fc6d3fa2cd887e7/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/816f6790e1d58d4e25d224755fc6d3fa2cd887e7/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/816f6790e1d58d4e25d224755fc6d3fa2cd887e7/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/816f6790e1d58d4e25d224755fc6d3fa2cd887e7/ios/chrome/browser/ios_chrome_flag_descriptions.h
,
Jun 19 2017
Verified fix in 61.0.3134.0 on iOS 10.3
,
Jun 20 2017
Verified on 61.0.3136.0 on iPad Pro iOS 10.2.1 , iPhone7 + iOS 10.2.1 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by elawrence@chromium.org
, Jun 15 2017Status: Assigned (was: Untriaged)