Add overall tracking for how often In-Product Help triggers |
|||||||
Issue descriptionChrome Version: 60.0.3112.33 OS: Android What steps will reproduce the problem? (1) Trigger In-Product Help What is the expected result? An overall stat should be incremented. What happens instead? Only "per feature" (per in-product help) stat is recorded through: InProductHelp.ShouldTriggerHelpUI.* But we want an overall one to figure out how often In-Product Help triggers. This could be solved in one of two ways: A) Create a dashboard that sums across all IPH features. B) Add another histogram that's total instead of per-feature.
,
Jun 21 2017
,
Jul 10 2017
,
Jul 10 2017
,
Jul 10 2017
,
Jul 13 2017
,
Jul 13 2017
CL in the works: https://chromium-review.googlesource.com/c/569259
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ffe5f17aaf5507df844b3e89606e854abf4ac41 commit 1ffe5f17aaf5507df844b3e89606e854abf4ac41 Author: Tommy Nyquist <nyquist@chromium.org> Date: Fri Jul 14 23:42:25 2017 Add overall histogram for triggering in-product help. Up until now, each in-product help feature has recorded their own histogram for how often they are triggered. However, this makes it hard to inspect the overall data for how often in-product help is triggered in general. This CL therefore adds a new histogram that is triggered regardless of which feature invoked it: InProductHelp.ShouldTriggerHelpUI. That name is also the base name for the suffix-based feature specific histograms. In addition, tests are added to ensure these histograms behave as expected. BUG= 733799 Change-Id: I9c99494dc64f9c20fc2e811d7596ff0d7a7f72c2 Reviewed-on: https://chromium-review.googlesource.com/569259 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#486942} [modify] https://crrev.com/1ffe5f17aaf5507df844b3e89606e854abf4ac41/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl_unittest.cc [modify] https://crrev.com/1ffe5f17aaf5507df844b3e89606e854abf4ac41/components/feature_engagement_tracker/internal/stats.cc [modify] https://crrev.com/1ffe5f17aaf5507df844b3e89606e854abf4ac41/tools/metrics/histograms/histograms.xml
,
Jul 16 2017
Overall histogram added as InProductHelp.ShouldTriggerHelpUI. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by talo@chromium.org
, Jun 15 2017