New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733793 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Remove the Native CUPS flag

Project Member Reported by skau@chromium.org, Jun 15 2017

Issue description

We don't need --disable-native-cups anymore.  Remove it from Chrome to keep things simple.
 

Comment 1 by skau@chromium.org, Jun 15 2017

Labels: M-62

Comment 2 by skau@chromium.org, Jun 16 2017

Components: Internals>Printing>CUPS
Labels: -M-62 M-61
Labels: -Pri-3 Pri-1
Bumping this bug up in priority :)

Comment 6 by skau@chromium.org, Jul 17 2017

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80e92e76b7717b0c52f050e7792f52c714324393

commit 80e92e76b7717b0c52f050e7792f52c714324393
Author: Sean Kau <skau@chromium.org>
Date: Fri Jul 21 17:37:11 2017

Remove the --disable-native-cups flag.

Native CUPS has been turned on since M59 and it has settled well.
The flag to turn it off is being removed.  Also clean up code that is
now extraneous.

Bug:  733793 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I351790c7f8f0a486743e190355af7922b0105676
Reviewed-on: https://chromium-review.googlesource.com/575829
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488695}
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/browser/about_flags.cc
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/browser/resources/options/browser_options.js
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/browser/resources/settings/printing_page/printing_page.js
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/common/chrome_switches.cc
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/common/chrome_switches.h
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/printing/backend/print_backend.cc
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/printing/backend/print_backend.h
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/printing/backend/print_backend_chromeos.cc
[modify] https://crrev.com/80e92e76b7717b0c52f050e7792f52c714324393/printing/printing_context_chromeos.cc

Comment 8 by skau@chromium.org, Jul 21 2017

Labels: Merge-Request-61
Just missed the branch.

Comment 9 by skau@chromium.org, Jul 21 2017

Status: Fixed (was: Started)
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 22 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 24 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a

commit 50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a
Author: Sean Kau <skau@chromium.org>
Date: Mon Jul 24 23:13:07 2017

Remove the --disable-native-cups flag.

Native CUPS has been turned on since M59 and it has settled well.
The flag to turn it off is being removed.  Also clean up code that is
now extraneous.

TBR=skau@chromium.org

(cherry picked from commit 80e92e76b7717b0c52f050e7792f52c714324393)

Bug:  733793 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I351790c7f8f0a486743e190355af7922b0105676
Reviewed-on: https://chromium-review.googlesource.com/575829
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488695}
Reviewed-on: https://chromium-review.googlesource.com/583480
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#17}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/browser/about_flags.cc
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/browser/resources/options/browser_options.js
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/browser/resources/settings/printing_page/printing_page.js
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/common/chrome_switches.cc
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/common/chrome_switches.h
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/printing/backend/print_backend.cc
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/printing/backend/print_backend.h
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/printing/backend/print_backend_chromeos.cc
[modify] https://crrev.com/50c8bed7354a4d9b0b151ec1b3c6a6b79ca6216a/printing/printing_context_chromeos.cc

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment