New issue
Advanced search Search tips

Issue 733792 link

Starred by 1 user
Status: Duplicate
Merged: issue 648343
Owner: ----
Closed: Jun 2017
Cc:
hinoka@chromium.org
aga...@chromium.org
iannu...@google.com
chrome-trooper-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"commit-git-patch" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 15 2017 
"commit-git-patch" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is not infrastructure-related (e.g. flaky test), please add Sheriff-Chromium label and change issue status to Untriaged. When done, please remove the issue from Trooper Bug Queue by removing the Infra-Troopers label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyGwsSBUZsYWtlIhBjb21taXQtZ2l0LXBhdGNoDA.

The chromium-try-flakes app is able to file bugs for individual tests when the test launcher is uploading results to the Test Results Server. If recent flakes above are caused by failing tests and you would like to have them filed as invidual bugs, please read more at https://goo.gl/QJKXV4.

This flaky test/step was previously tracked in  issue 716388 .

Comment 1 by s...@google.com, Jun 15 2017

Cc: aga...@chromium.org hinoka@chromium.org
Components: Infra>Platform>Recipes
It looks like the patch is applied by bot_update then commit-git-patch has nothing to do. In all four cases it was the same DEPS change. I'd guess that because it has to do a sync when applying a DEPS change, it commits the patch locally as part of applying it then commit-git-patch is unnecessary. I haven't verified this yet but if true then maybe we could add --allow-empty to commit-git-patch.

Comment 2 by aga...@chromium.org, Jun 16 2017

Mergedinto: 648343
Status: Duplicate (was: Untriaged)
This is a manifestation of issue 648343. The CL which was being tried was identical to a change which had already landed, so the patch (after three-way-merge) resulted in 0 diff. That's why there was nothing to commit. If bot_update were to bail out when the patch results in no diff, that would reduce confusion in this case.
►

Sign in to add a comment