New issue
Advanced search Search tips

Issue 733779 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
liaoyuke@chromium.org
dpranke@chromium.org
justincohen@chromium.org
sdefresne@chromium.org
rohitrao@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Analyzer thinks ios/chrome/app/chrome_exe_main.mm change does not affect ios unit test and integration targets

Project Member Reported by liaoyuke@chromium.org, Jun 15 2017 
This CL makes changes to ios/chrome/app/chrome_exe_main.mm
https://chromium-review.googlesource.com/c/534874/

However, all try jobs and CQs are skipped
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/238196

Comment 1 by rohitrao@chromium.org, Jun 15 2017 

I think this is correct?  chrome_exe_main.mm is only linked into the Chromium app, so unittests do not depend on it at all.

All egtest binaries should depend on this file, but egtests were not running on the CQ at the time that this tryjob was submitted.

Comment 2 by liaoyuke@chromium.org, Jun 15 2017

Labels: -Pri-1 Pri-2
I'm not sure how Analyzer works, but changes to chrome_exe_main.mm could break our unit tests, can we somehow make it re-run?

Comment 3 by liaoyuke@chromium.org, Jun 15 2017

Status: WontFix (was: Available)
Woops, I just realized that changes to chrome_exe_main.mm won't break unit tests, it only breaks egtests, which makes sense now, so I'm marking this bug as wontFix.
►

Sign in to add a comment