New issue
Advanced search Search tips

Issue 733768 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK in PolicyProvider::UpdateManagedDefaultSetting

Project Member Reported by wfh@chromium.org, Jun 15 2017

Issue description

Chrome Version: 61.0.3132.0 git rev 35f9f27a8760a9bb9e803dacbc9e5903836cfd30
OS: Mac OS X El Capitan 10.11.6

What steps will reproduce the problem?
(1) compile chrome with DCHECK enabled
(2) run chrome with a --user-data-dir pointing at empty dir
(3)

What is the expected result?

no crash

What happens instead?

crash

Please use labels and text to provide additional information.

gn args are:

# Build arguments go here.
# See "gn args <out_dir> --list" for available build arguments.
is_debug = false
is_component_build = false
enable_nacl = false
is_chrome_branded = true
dcheck_always_on = true
symbol_level = 1
use_goma = true
goma_dir = "/Users/wfh/goma/goma-mac"


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

[37836:1295:0615/122043.400746:FATAL:content_settings_policy_provider.cc(353)] Check failed: !prefs_->HasPrefPath(entry.pref_name) || prefs_->IsManagedPreference(entry.pref_name).
0   Google Chrome Framework             0x00000001088a4a2c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   Google Chrome Framework             0x00000001088c99e0 logging::LogMessage::~LogMessage() + 224
2   Google Chrome Framework             0x000000010a942956 content_settings::PolicyProvider::UpdateManagedDefaultSetting(content_settings::PolicyProvider::PrefsForManagedDefaultMapEntry const&) + 454
3   Google Chrome Framework             0x000000010a94113e content_settings::PolicyProvider::ReadManagedDefaultSettings() + 126
4   Google Chrome Framework             0x000000010a9401b2 content_settings::PolicyProvider::PolicyProvider(PrefService*) + 98
5   Google Chrome Framework             0x000000010a94c0ef HostContentSettingsMap::HostContentSettingsMap(PrefService*, bool, bool, bool) + 463
6   Google Chrome Framework             0x00000001082c6f5e HostContentSettingsMapFactory::BuildServiceInstanceFor(content::BrowserContext*) const + 334
7   Google Chrome Framework             0x000000010b55880f RefcountedBrowserContextKeyedServiceFactory::BuildServiceInstanceFor(base::SupportsUserData*) const + 15
8   Google Chrome Framework             0x000000010a88f9f8 RefcountedKeyedServiceFactory::GetServiceForContext(base::SupportsUserData*, bool) + 216
9   Google Chrome Framework             0x000000010b558731 RefcountedBrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) + 17
10  Google Chrome Framework             0x00000001082c6d08 HostContentSettingsMapFactory::GetForProfile(Profile*) + 120
11  Google Chrome Framework             0x00000001082c6b0c CookieSettingsFactory::BuildServiceInstanceFor(content::BrowserContext*) const + 252
12  Google Chrome Framework             0x000000010b55880f RefcountedBrowserContextKeyedServiceFactory::BuildServiceInstanceFor(base::SupportsUserData*) const + 15
13  Google Chrome Framework             0x000000010a88f9f8 RefcountedKeyedServiceFactory::GetServiceForContext(base::SupportsUserData*, bool) + 216
14  Google Chrome Framework             0x000000010b558731 RefcountedBrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) + 17
15  Google Chrome Framework             0x00000001082c6822 CookieSettingsFactory::GetForProfile(Profile*) + 194
16  Google Chrome Framework             0x00000001084691dd ProfileImpl::GetExtensionSpecialStoragePolicy() + 93
17  Google Chrome Framework             0x00000001084675ec ProfileImpl::DoFinalInit() + 2652
18  Google Chrome Framework             0x00000001084697e8 ProfileImpl::OnLocaleReady() + 1224
19  Google Chrome Framework             0x0000000108466aed ProfileImpl::OnPrefsLoaded(Profile::CreateMode, bool) + 173
20  Google Chrome Framework             0x000000010846676f ProfileImpl::ProfileImpl(base::FilePath const&, Profile::Delegate*, Profile::CreateMode, base::SequencedTaskRunner*) + 2495
21  Google Chrome Framework             0x000000010846499b Profile::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) + 331
22  Google Chrome Framework             0x0000000108488d87 ProfileManager::CreateProfileHelper(base::FilePath const&) + 71
23  Google Chrome Framework             0x000000010848212a ProfileManager::CreateAndInitializeProfile(base::FilePath const&) + 138
24  Google Chrome Framework             0x0000000108481e2e ProfileManager::GetProfile(base::FilePath const&) + 78
25  Google Chrome Framework             0x000000010bc709a5 GetStartupProfile(base::FilePath const&, base::CommandLine const&) + 69
26  Google Chrome Framework             0x00000001082a2586 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 1990
27  Google Chrome Framework             0x00000001082a1cbe ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
28  Google Chrome Framework             0x00000001069234a3 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
29  Google Chrome Framework             0x0000000106dd2f27 content::StartupTaskRunner::RunAllTasksNow() + 39
30  Google Chrome Framework             0x0000000106921b22 content::BrowserMainLoop::CreateStartupTasks() + 658
31  Google Chrome Framework             0x000000010692650a content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 842
32  Google Chrome Framework             0x000000010691f464 content::BrowserMain(content::MainFunctionParams const&) + 100
33  Google Chrome Framework             0x000000010823f025 content::ContentMainRunnerImpl::Run() + 1045
34  Google Chrome Framework             0x000000010a489efe service_manager::Main(service_manager::MainParams const&) + 2574
35  Google Chrome Framework             0x000000010823e214 content::ContentMain(content::ContentMainParams const&) + 68
36  Google Chrome Framework             0x0000000106063a58 ChromeMain + 168
37  Google Chrome                       0x0000000105dfbda4 main + 404
38  libdyld.dylib                       0x00007fff8d7275ad start + 1

 

Comment 1 by wfh@chromium.org, Jun 15 2017

Components: Internals>Preferences

Comment 2 by tapted@chromium.org, Jun 16 2017

Cc: blumberg@chromium.org
Components: Enterprise
[mac triage] I think this is an Enterprise Policy thing?

Comment 3 by tapted@chromium.org, Jun 16 2017

Cc: -blumberg@chromium.org
Owner: blumberg@chromium.org
Status: Assigned (was: Untriaged)
[mac triage - I thought that would take it out of the triage queue, but it didn't]
Owner: georgesak@chromium.org

Comment 5 by wfh@chromium.org, Jun 25 2018

I'm still getting this.

Here is the stack from latest rev I synced to (d15bcae0ad81850478cbb5e8218da8ae134d820d)

[1095:775:0625/150601.109418:FATAL:content_settings_policy_provider.cc(380)] Check failed: !prefs_->HasPrefPath(entry.pref_name) || prefs_->IsManagedPreference(entry.pref_name). 
0   Google Chrome Framework             0x0000000112d0721c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   Google Chrome Framework             0x0000000112c297ff logging::LogMessage::~LogMessage() + 223
2   Google Chrome Framework             0x0000000114d368a8 content_settings::PolicyProvider::UpdateManagedDefaultSetting(content_settings::PolicyProvider::PrefsForManagedDefaultMapEntry const&) + 472
3   Google Chrome Framework             0x0000000114d34add content_settings::PolicyProvider::ReadManagedDefaultSettings() + 141
4   Google Chrome Framework             0x0000000114d338b2 content_settings::PolicyProvider::PolicyProvider(PrefService*) + 98
5   Google Chrome Framework             0x0000000114d40974 HostContentSettingsMap::HostContentSettingsMap(PrefService*, bool, bool, bool) + 484
6   Google Chrome Framework             0x000000011271783c HostContentSettingsMapFactory::BuildServiceInstanceFor(content::BrowserContext*) const + 316
7   Google Chrome Framework             0x0000000115968f7f RefcountedBrowserContextKeyedServiceFactory::BuildServiceInstanceFor(base::SupportsUserData*) const + 15
8   Google Chrome Framework             0x0000000114cf2fa4 RefcountedKeyedServiceFactory::GetServiceForContext(base::SupportsUserData*, bool) + 212
9   Google Chrome Framework             0x0000000115968e9e RefcountedBrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) + 14
10  Google Chrome Framework             0x0000000112717598 HostContentSettingsMapFactory::GetForProfile(Profile*) + 120
11  Google Chrome Framework             0x000000011271738b CookieSettingsFactory::BuildServiceInstanceFor(content::BrowserContext*) const + 251
12  Google Chrome Framework             0x0000000115968f7f RefcountedBrowserContextKeyedServiceFactory::BuildServiceInstanceFor(base::SupportsUserData*) const + 15
13  Google Chrome Framework             0x0000000114cf2fa4 RefcountedKeyedServiceFactory::GetServiceForContext(base::SupportsUserData*, bool) + 212
14  Google Chrome Framework             0x0000000115968e9e RefcountedBrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) + 14
15  Google Chrome Framework             0x0000000112717053 CookieSettingsFactory::GetForProfile(Profile*) + 195
16  Google Chrome Framework             0x00000001128e7c9a ProfileImpl::GetExtensionSpecialStoragePolicy() + 90
17  Google Chrome Framework             0x00000001128e5e8a ProfileImpl::DoFinalInit() + 3978
18  Google Chrome Framework             0x00000001128e8293 ProfileImpl::OnLocaleReady() + 1219
19  Google Chrome Framework             0x00000001128e4e5d ProfileImpl::OnPrefsLoaded(Profile::CreateMode, bool) + 173
20  Google Chrome Framework             0x00000001128e4a79 ProfileImpl::ProfileImpl(base::FilePath const&, Profile::Delegate*, Profile::CreateMode, scoped_refptr<base::SequencedTaskRunner>) + 2409
21  Google Chrome Framework             0x00000001128e2cd9 Profile::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) + 345
22  Google Chrome Framework             0x0000000112903af7 ProfileManager::CreateProfileHelper(base::FilePath const&) + 71
23  Google Chrome Framework             0x00000001128fccba ProfileManager::CreateAndInitializeProfile(base::FilePath const&) + 138
24  Google Chrome Framework             0x00000001128fc97e ProfileManager::GetProfile(base::FilePath const&) + 78
25  Google Chrome Framework             0x000000011622b4b5 GetStartupProfile(base::FilePath const&, base::CommandLine const&) + 69
26  Google Chrome Framework             0x00000001126e97c8 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 2008
27  Google Chrome Framework             0x00000001126e8eee ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
28  Google Chrome Framework             0x000000011040d5d3 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
29  Google Chrome Framework             0x0000000110995995 content::StartupTaskRunner::RunAllTasksNow() + 117
30  Google Chrome Framework             0x000000011040bda2 content::BrowserMainLoop::CreateStartupTasks() + 914
31  Google Chrome Framework             0x0000000110410255 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 101
32  Google Chrome Framework             0x0000000110409a95 content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 229
33  Google Chrome Framework             0x000000011267dc7e content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 190
34  Google Chrome Framework             0x000000011267ebe7 content::ContentMainRunnerImpl::Run() + 807
35  Google Chrome Framework             0x0000000114927c87 service_manager::Main(service_manager::MainParams const&) + 2855
36  Google Chrome Framework             0x000000011267db94 content::ContentMain(content::ContentMainParams const&) + 68
37  Google Chrome Framework             0x000000010f151953 ChromeMain + 179
38  Google Chrome                       0x0000000100719dd2 main + 386
39  libdyld.dylib                       0x00007fffdf96d235 start + 1
Cc: zmin@chromium.org georgesak@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)

Comment 7 by pmarko@chromium.org, Jun 27 2018

Cc: pmarko@chromium.org
Owner: pmarko@chromium.org
Taking this to attempt to reproduce.

It seems that when pointing to an empty user profile dir, we'd expect the pref to not be in the user's pref store (because there were no prefs).

So I'd assume it's coming from policy. One reason why IsManagedPreference would return false would be that the pref is "only" recommended.

Another guess would be that there's a bug in the policy->pref mappings.

wfh@, could you please comment out the DCHECK (or run a build without DHCECKs), then when chrome loads, go to chrome://policy and check if any of these are set and what their 'Level' is?
- AdsSettingForIntrusiveAdsSites
- DefaultCookiesSetting
- DefaultImagesSetting
- DefaultGeolocationSetting
- DefaultJavaScriptSetting
- DefaultMediaStreamSetting
- DefaultNotificationsSetting
- DefaultPluginsSetting
- DefaultPopupsSetting
- DefaultWebBluetoothGuardSetting
- DefaultWebUsbGuardSetting

Thanks!

wfh@ - Friendly ping.


Anyway, it seems that policies are "recommended" by default on mac which could explain this - see  bug 859185  and bug 860633.
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment