MD Settings: Stop including "proxy" interfaces in shipped code |
|||
Issue descriptionbrowser proxy interfaces are only needed for type checking. Currently they co-reside in the same file as the implementation version, and therefore they are being shipped in the final binary. I am proposing to split them to separate files, which will not be part of settings's grd file. Approach 1: - Create a chrome/browser/resources/settings/interfaces/ folder - Put all proxy interfaces under that folder (in separate files). Approcah 2: - Keep the proxy interfaces where they reside today. - Move the implementaion outside of foo_proxy.js to foo_proxy_impl.js I don't see big cons/pros of either approach. #1 would provide a central spot that describes all proxy-based communication between JS and C++, which maybe be better for readability? Any thoughts?
,
Jun 15 2017
What would go in the expr="" condition to achieve this? Some dummy false value? Even if this is possible, I prefer not using the <if expr> mechanism, because in theory, we should be GRIT processing our sources before we pass them to the Closure Compiler. We don't do that yet, and it causes problems that we currently work around them.
,
Jun 15 2017
Sounds good, just wanted to ask.
,
Jun 15 2017
<if expr="False"> sounds like a glorious, total hack
,
Aug 1
,
Dec 13
I am closing this. The motivation for this was comparing Mojo interfaces and browser proxy interfaces as part of Mojo WebUI investigation. That work has recently moved forward anyway, so this is no longer necessary. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dschuyler@chromium.org
, Jun 15 2017