New issue
Advanced search Search tips

Issue 733737 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 752101



Sign in to add a comment

Google-A wifi network reconnected after login when I previously 'forgot' it

Project Member Reported by jhawkins@chromium.org, Jun 15 2017

Issue description

Chrome Version: 61.0.3129.0
OS: CrOS

What steps will reproduce the problem?
(1) Wifi settings -> Google-A -> Disconnect & Forget
(2) Close Chromebook (or lock screen I guess)
(3) Log back in

What is the expected result?

No wifi connection to Google-A

What happens instead?

Google-A is connected

 
Cc: -steve...@chromium.org tbuck...@chromium.org emaxx@chromium.org
Labels: M-62
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
Enterprise installed networks can't actually be forgotten. The bug here is that we shouldn't show the 'forget' button.

Labels: Hotlist-MD-Settings-Internet
Blocking: 752101
Labels: -Pri-3 -M-62 M-60 Pri-1
Status: Started (was: Assigned)
Upping the priority on this because it exposes some unexpected behavior when a device-policy network is forgotten.

Cc: atwilson@chromium.org maxkirsch@chromium.org tbarzic@chromium.org
Labels: ReleaseBlock-Stable
Ok, please update when fix is available for this, since M60 is already stable we should limit the scope of the change as much as we can to reduce any potential impact/side effect

Is this fix also addressing  issue 752101 ?
Components: UI>Settings
The fix is here, it's a pretty safe/small UI change:
https://chromium-review.googlesource.com/c/616077

It does not fix the underlying problems discussed in  issue 752101 , but it effectively solves the problem by preventing users from removing device-policy networks in the UI.

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbc44c77b42411eac4226c69228da92e2d09d48c

commit fbc44c77b42411eac4226c69228da92e2d09d48c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Aug 16 02:14:32 2017

Settings: Internet: Hide/disable Forget for policy networks

This CL:
* Hides the 'Forget' buttons for policy networks since 'Forget' is
  not allowed (or for device-policy networks behavies unexpectedly).
* Disables the 'Forget' menu item (we do not remove it to avoid
  empty networks)
* Adds an enterprise item to policy controlled networks to match the
  primary network list and to make the reason for 'Forget' being
  disabled more apparent.

Bug:  733737 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iadc3cf08cff543a0df1d0013eb5cb72fd044d822
Reviewed-on: https://chromium-review.googlesource.com/616077
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494668}
[modify] https://crrev.com/fbc44c77b42411eac4226c69228da92e2d09d48c/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/fbc44c77b42411eac4226c69228da92e2d09d48c/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/fbc44c77b42411eac4226c69228da92e2d09d48c/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

Labels: Merge-Request-60
Status: Fixed (was: Started)
Requesting Merge for 60; will also request for 61 once merged to 60.

Labels: -Merge-Request-60 M-61 Merge-Approved-60 Merge-Approved-61
Let's also merge to M-61 
Approved for M-60 and M-61

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 22 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaa2c973c06bdd2b9e1e4363ebda9aee8f7fdb6e

commit aaa2c973c06bdd2b9e1e4363ebda9aee8f7fdb6e
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Aug 22 16:27:36 2017

Settings: Internet: Hide/disable Forget for policy networks

This CL:
* Hides the 'Forget' buttons for policy networks since 'Forget' is
  not allowed (or for device-policy networks behavies unexpectedly).
* Disables the 'Forget' menu item (we do not remove it to avoid
  empty networks)
* Adds an enterprise item to policy controlled networks to match the
  primary network list and to make the reason for 'Forget' being
  disabled more apparent.

TBR=stevenjb@chromium.org

(cherry picked from commit fbc44c77b42411eac4226c69228da92e2d09d48c)

Bug:  733737 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iadc3cf08cff543a0df1d0013eb5cb72fd044d822
Reviewed-on: https://chromium-review.googlesource.com/616077
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494668}
Reviewed-on: https://chromium-review.googlesource.com/626360
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#742}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/aaa2c973c06bdd2b9e1e4363ebda9aee8f7fdb6e/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/aaa2c973c06bdd2b9e1e4363ebda9aee8f7fdb6e/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/aaa2c973c06bdd2b9e1e4363ebda9aee8f7fdb6e/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 22 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf91097adfcfc7467adb95ad15ca37af971495bd

commit bf91097adfcfc7467adb95ad15ca37af971495bd
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Aug 22 17:35:01 2017

Settings: Internet: Hide/disable Forget for policy networks

This CL:
* Hides the 'Forget' buttons for policy networks since 'Forget' is
  not allowed (or for device-policy networks behavies unexpectedly).
* Disables the 'Forget' menu item (we do not remove it to avoid
  empty networks)
* Adds an enterprise item to policy controlled networks to match the
  primary network list and to make the reason for 'Forget' being
  disabled more apparent.

TBR=stevenjb@chromium.org

(cherry picked from commit fbc44c77b42411eac4226c69228da92e2d09d48c)

Bug:  733737 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iadc3cf08cff543a0df1d0013eb5cb72fd044d822
Reviewed-on: https://chromium-review.googlesource.com/616077
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494668}
Reviewed-on: https://chromium-review.googlesource.com/626677
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#756}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/bf91097adfcfc7467adb95ad15ca37af971495bd/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/bf91097adfcfc7467adb95ad15ca37af971495bd/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/bf91097adfcfc7467adb95ad15ca37af971495bd/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

Status: Verified (was: Fixed)
As verified in M60.0.3112.114:9592.90.0 stable hana and M61.0.3163.72:9765.50.0 beta peppy, the "Forget" button is not available for policy managed networks thus this issue should not happen again.

Sign in to add a comment