New issue
Advanced search Search tips

Issue 733733 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Instant apps banners immediately disappearing

Project Member Reported by thildebr@chromium.org, Jun 15 2017

Issue description

In some cases, an Instant App banner will show up briefly only to be removed when the navigation completes and we consider it ignored.

What steps will reproduce the problem?
(1) Go to buzzfeed.com/tasty
(2) Ensure the banner isn't ignored, reset site settings.
(3) Click the "Tasty" link in the top left to load the page again.

What is the expected result?
Instant Apps banner shows up and stays visible.

What happens instead?
Instant Apps banner shows up briefly and then disappears.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/885e2ac5ae23ba1fbc31051bcf1cde28b38e0259

commit 885e2ac5ae23ba1fbc31051bcf1cde28b38e0259
Author: Troy Hildebrandt <thildebr@chromium.org>
Date: Sat Aug 12 00:21:55 2017

Fix instant apps banners immediately disappearing.

Compares the URL the instant app banner was launched on with the current
WebContents URL to ensure we're not mistakenly dismissing banners on the
same page they were launched.

This check occurs before we use the general InfoBar ShouldExpire(),
which was using the NavigationDetails to see if this was the same page,
which is untrue on a redirect.

TBR=pkasting@chromium.org

Bug: 754095, 733733 
Change-Id: Iabc2b307b909c553e985d7a2fc5ed5f50ace6bb0
Reviewed-on: https://chromium-review.googlesource.com/612112
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493894}
[modify] https://crrev.com/885e2ac5ae23ba1fbc31051bcf1cde28b38e0259/chrome/browser/android/instantapps/instant_apps_infobar_delegate.cc
[modify] https://crrev.com/885e2ac5ae23ba1fbc31051bcf1cde28b38e0259/chrome/browser/android/instantapps/instant_apps_infobar_delegate.h
[modify] https://crrev.com/885e2ac5ae23ba1fbc31051bcf1cde28b38e0259/components/infobars/core/infobar_delegate.h

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39e3e5d18e666ae2f3d0a384ffc12ab273d29b68

commit 39e3e5d18e666ae2f3d0a384ffc12ab273d29b68
Author: Troy Hildebrandt <thildebr@chromium.org>
Date: Tue Aug 15 19:22:27 2017

Fix recently const broken InfoBarDelegate.

InfoBarDelegate's infobar() method was recently made const broken
according to the Chromium C++ Dos and Don'ts guidelines (my bad.)

This fix makes InfoBarDelegate const correct again, and now stores a
reference to the WebContents within the InstantAppsInfoBarDelegate so
we don't need to get WebContents from the info bar using infobar().

TBR=pkasting@chromium.org

Bug:  733733 
Change-Id: I8fe56be7ddb39d29db2661434348e9a813e55e1c
Reviewed-on: https://chromium-review.googlesource.com/613674
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494489}
[modify] https://crrev.com/39e3e5d18e666ae2f3d0a384ffc12ab273d29b68/chrome/browser/android/instantapps/instant_apps_infobar_delegate.cc
[modify] https://crrev.com/39e3e5d18e666ae2f3d0a384ffc12ab273d29b68/chrome/browser/android/instantapps/instant_apps_infobar_delegate.h
[modify] https://crrev.com/39e3e5d18e666ae2f3d0a384ffc12ab273d29b68/components/infobars/core/infobar_delegate.h

Status: Fixed (was: Started)
Customwriting.com is one of the best among content writing companies. We provide 24/7 online support in case you need us right now! To place an order is very easy. You mention all the details and subtleties concerning your work and we will take that into account! Do not be afraid in terms of payment! You are not supposed to pay beforehand. 
Website: https://customwriting.com/

Sign in to add a comment