Migrate ash::WallpaperController to TaskScheduler for image resize |
|||
Issue descriptionForked off Issue 733641 I'm trying to get rid of ShellInitParams::blocking_pool, which is injected into ash and used in a couple places to run tasks. One of them is wallpaper_controller.cc, which seems to use it to schedule slow image resize operations on a background thread. I think this could just be a base::PostTask(), but I'm not sure if this needs to be sequenced with other tasks. I may use a sequenced task runner just to be safe. https://chromium.googlesource.com/chromium/src/+/master/docs/threading_and_tasks.md bruthig, do you know if these resize operations are ordered with other tasks?
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08fc8ce2552afb84f744098329d51b346465dd16 commit 08fc8ce2552afb84f744098329d51b346465dd16 Author: James Cook <jamescook@chromium.org> Date: Thu Jun 15 19:29:33 2017 chromeos: Convert ash::WallpaperController to use TaskScheduler This is a step toward removing the dependency-injected blocking pool in ash::Shell (via ash::ShellInitParams). It will also allows wallpaper related tasks to run in parallel with the other blocking pool user (ICC color calibration file loading). Bug: 733728 , 667892 Test: ash_unittests Change-Id: I3116fd324b7c8a9f77cb4a964ec7f5d93160dfa6 Reviewed-on: https://chromium-review.googlesource.com/537452 Reviewed-by: Ben Ruthig <bruthig@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#479781} [modify] https://crrev.com/08fc8ce2552afb84f744098329d51b346465dd16/ash/shell.cc [modify] https://crrev.com/08fc8ce2552afb84f744098329d51b346465dd16/ash/shell.h [modify] https://crrev.com/08fc8ce2552afb84f744098329d51b346465dd16/ash/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/08fc8ce2552afb84f744098329d51b346465dd16/ash/wallpaper/wallpaper_controller.h [modify] https://crrev.com/08fc8ce2552afb84f744098329d51b346465dd16/ash/wallpaper/wallpaper_controller_unittest.cc
,
Jun 15 2017
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jamescook@chromium.org
, Jun 15 2017