Issue metadata
Sign in to add a comment
|
git cl issue can't assign branch to a gerrit issue |
||||||||||||||||||||||
Issue descriptionAffected Version: What steps will reproduce the problem? 1. run git cl issue 2. pass a gerrit issue # or URL 3. git cl issue fails or assigns the wrong issue URL What is the expected output? git cl assigns the correct issue URL What do you see instead? mfoltz@mfoltz-macpro /Users/mfoltz/chrome/src]$ git cl issue https://chromium-review.googlesource.com/c/535241 Pass a number to set the issue or none to list it. Maybe you want to run git cl status? [mfoltz@mfoltz-macpro /Users/mfoltz/chrome/src]$ git cl issue 535241 Issue number: 535241 (https://chromium-review.googlesource.com/535241) [mfoltz@mfoltz-macpro /Users/mfoltz/chrome/src]$ git cl issue c/535241 Pass a number to set the issue or none to list it. Maybe you want to run git cl status?
,
Jun 14 2017
,
Jun 15 2017
"git cl issue" has never taken a url as input. It's certainly a feature to consider, similar to how "git cl patch" accepts urls as input, but not a regression. The url that it sets is a valid url which goes to the right place (it's the canonical "UI-agnostic" url, whereas /c/number is PolyGerrit and #/c/number is the old GWT UI), so there shouldn't be any problem there. All that said, making it accept a url is super easy, so I've done that here: https://chromium-review.googlesource.com/537113
,
Jun 15 2017
,
Jun 15 2017
,
Jun 15 2017
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/78753da20ee812116f2cec5daed8a22b20e66352 commit 78753da20ee812116f2cec5daed8a22b20e66352 Author: Aaron Gable <agable@chromium.org> Date: Thu Jun 15 17:51:02 2017 Accept URLs in 'git cl issue' There's no reason not to, since it is pretty easy, and other commands like "git cl patch" already do so. Bug: 733715 Change-Id: I3396153ef11bfdbbf09b8a7f54f9a5b1047e290f Reviewed-on: https://chromium-review.googlesource.com/537113 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/78753da20ee812116f2cec5daed8a22b20e66352/git_cl.py
,
Jun 15 2017
Enjoy your newfound url-using powers :) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mfo...@chromium.org
, Jun 14 2017