Better support for Windows virtual keyboard detection |
|||
Issue descriptionA couple features depend on LocationBarView::IsVirtualKeyboardVisible[1] but that only works for the ash virtual keyboard. We need to extend it to work for the Windows one as well. It seems there's code to detect it in ui/base/win/osk_display_manager.cc but it currently just allows listening for showing (which is async) and hiding, rather than statically checking whether a keyboard is visible. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/views/location_bar/location_bar_view.cc?rcl=2ec4013ac56a7f30db385949269adc21ae980bf3&l=743
,
Jul 7 2017
Patch is at https://codereview.chromium.org/2971363002
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/931654e2e2b4c27ff7f2234fb3115f4ad2eb1cd3 commit 931654e2e2b4c27ff7f2234fb3115f4ad2eb1cd3 Author: girard <girard@chromium.org> Date: Thu Jul 20 14:54:57 2017 Detect if osk is visible on windows BUG= 733710 Review-Url: https://codereview.chromium.org/2971363002 Cr-Commit-Position: refs/heads/master@{#488244} [modify] https://crrev.com/931654e2e2b4c27ff7f2234fb3115f4ad2eb1cd3/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/931654e2e2b4c27ff7f2234fb3115f4ad2eb1cd3/ui/base/win/osk_display_manager.cc [modify] https://crrev.com/931654e2e2b4c27ff7f2234fb3115f4ad2eb1cd3/ui/base/win/osk_display_manager.h
,
Jul 20 2017
This can be tested by testing issue 718037 on Windows devices. Check that the "clear all" button appears while you're typing in the omnibox with the virtual keyboard (and that it doesn't appear if the osk is not shown.) |
|||
►
Sign in to add a comment |
|||
Comment 1 by est...@chromium.org
, Jun 15 2017