Clean color extraction codes up in WallpaperManager when old login screen is deprecated |
||||||||
Issue descriptionClean up or revert CL https://codereview.chromium.org/2931063004/ when new login screen is in use (~M63). By that time we'll be able to combine color extraction for login screen and shelf together because they share the same code logic and similar color scheme. Spec is attached for reference: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCEk7MHTx6J1uvY37ouyEwq7wMSJbxAVNpw
,
Aug 9 2017
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f173c27a3e622bbce37aaf7dead6decf412aa1f1 commit f173c27a3e622bbce37aaf7dead6decf412aa1f1 Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Aug 11 00:45:00 2017 Clear color calculation in |WallpaperManager| The original CL: https://codereview.chromium.org/2931063004/ for reference. Looks like |OnWallpaperColorsChanged()| doesn't need to be a virtual function, but needs to look into it and will address it in a new CL. Make SigninScreenHandler observer WallpaperController. This is only relevant if there're more than six users at login screen. Bug: 733709 Change-Id: I0c4a2e6a174252e66858234ec683b6bdee3ee3eb Reviewed-on: https://chromium-review.googlesource.com/608846 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#493623} [modify] https://crrev.com/f173c27a3e622bbce37aaf7dead6decf412aa1f1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc [modify] https://crrev.com/f173c27a3e622bbce37aaf7dead6decf412aa1f1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h [modify] https://crrev.com/f173c27a3e622bbce37aaf7dead6decf412aa1f1/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/f173c27a3e622bbce37aaf7dead6decf412aa1f1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/f173c27a3e622bbce37aaf7dead6decf412aa1f1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h [modify] https://crrev.com/f173c27a3e622bbce37aaf7dead6decf412aa1f1/components/wallpaper/wallpaper_manager_base.h [modify] https://crrev.com/f173c27a3e622bbce37aaf7dead6decf412aa1f1/ui/login/account_picker/md_screen_account_picker.css
,
Aug 11 2017
,
Aug 11 2017
This is not only a clean-up but is important for M61. No behavior/UI change but it avoids redundant color calculation.
,
Aug 11 2017
Pls apply appropriate OSs.
,
Aug 11 2017
Sorry.
,
Aug 11 2017
Approving merge to M61 Chrome OS.
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7e7c0588c3c32659fa2d2bf9708728cd26c561c commit d7e7c0588c3c32659fa2d2bf9708728cd26c561c Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Aug 11 17:57:15 2017 Clear color calculation in |WallpaperManager| The original CL: https://codereview.chromium.org/2931063004/ for reference. Looks like |OnWallpaperColorsChanged()| doesn't need to be a virtual function, but needs to look into it and will address it in a new CL. Make SigninScreenHandler observer WallpaperController. This is only relevant if there're more than six users at login screen. TBR=wzang@chromium.org (cherry picked from commit f173c27a3e622bbce37aaf7dead6decf412aa1f1) Bug: 733709 Change-Id: I0c4a2e6a174252e66858234ec683b6bdee3ee3eb Reviewed-on: https://chromium-review.googlesource.com/608846 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493623} Reviewed-on: https://chromium-review.googlesource.com/612482 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#493} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/d7e7c0588c3c32659fa2d2bf9708728cd26c561c/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc [modify] https://crrev.com/d7e7c0588c3c32659fa2d2bf9708728cd26c561c/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h [modify] https://crrev.com/d7e7c0588c3c32659fa2d2bf9708728cd26c561c/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/d7e7c0588c3c32659fa2d2bf9708728cd26c561c/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/d7e7c0588c3c32659fa2d2bf9708728cd26c561c/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h [modify] https://crrev.com/d7e7c0588c3c32659fa2d2bf9708728cd26c561c/components/wallpaper/wallpaper_manager_base.h [modify] https://crrev.com/d7e7c0588c3c32659fa2d2bf9708728cd26c561c/ui/login/account_picker/md_screen_account_picker.css
,
Aug 16 2017
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bruthig@chromium.org
, Jun 22 2017