Make lint-test-expectation also inspect {MSAN,ASAN,Leak}Expectations |
|||
Issue descriptionFor context, see bug 733130 and bug 733175 . Currently, these expectations files are not checked by lint-test-expectations because that script decide what files to look at using port_to_lint.all_expectations_dict(), and MSANExpectations (and LeakExpectations, ASANExpectations) are never in there. webkitpy/layout_tests/lint_test_expectations.py should be changed to also check those files.
,
Jun 19 2017
,
Jun 22 2017
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/840fe69e05acc2af3e863acfd1b40a62d06dae7c commit 840fe69e05acc2af3e863acfd1b40a62d06dae7c Author: Quinten Yearsley <qyearsley@google.com> Date: Fri Jun 23 15:28:35 2017 Make lint-test-expectations also lint LeakExpectations etc. Bug: 733696 Change-Id: Ifedf5c2d8a1e505240feeddfcda8c270fb6b4b7f Reviewed-on: https://chromium-review.googlesource.com/540267 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#481895} [modify] https://crrev.com/840fe69e05acc2af3e863acfd1b40a62d06dae7c/third_party/WebKit/LayoutTests/ASANExpectations [modify] https://crrev.com/840fe69e05acc2af3e863acfd1b40a62d06dae7c/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/840fe69e05acc2af3e863acfd1b40a62d06dae7c/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py [modify] https://crrev.com/840fe69e05acc2af3e863acfd1b40a62d06dae7c/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py
,
Jun 26 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by hajimehoshi@chromium.org
, Jun 19 2017