New issue
Advanced search Search tips

Issue 733692 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Roll clang to r305433 or higher

Project Member Reported by h...@chromium.org, Jun 15 2017

Issue description

We want r305433 for a fix that clusterfuzz relies on; see https://bugs.chromium.org/p/chromium/issues/detail?id=731130#c16
 

Comment 1 by h...@chromium.org, Jun 15 2017

Status: Started (was: Assigned)
Trying r305462: https://codereview.chromium.org/2937203003

Comment 2 by thakis@chromium.org, Jun 15 2017

Should we wait for phosek's driver change too?

Comment 3 by h...@chromium.org, Jun 15 2017

I don't think he sent it for review yet. Let's see how this one fares on the trybots in any case. If phosek's change lands soon maybe we can skip forward to it.
Cc: vitalyb...@chromium.org

Comment 5 by aarya@google.com, Jun 15 2017

Cc: och...@chromium.org infe...@chromium.org

Comment 6 by mmoroz@chromium.org, Jun 15 2017

Cc: mmoroz@chromium.org
Any chance to get r305489? It has one more fix for UBSan (issue 702459).

Comment 7 by h...@chromium.org, Jun 15 2017

> Any chance to get r305489? It has one more fix for UBSan (issue 702459).

I don't seem to have access; can you cc me on it?

Comment 8 by mmoroz@chromium.org, Jun 15 2017

Sure! Done.

Comment 9 by p...@chromium.org, Jun 15 2017

We should also get r305482 which includes a binary size improvement for --lto-O0 (presumably if you're going as far as r305489 then it should be included). We should hopefully be able to flip the ThinLTO switch on Linux once that lands.

Comment 10 by p...@chromium.org, Jun 15 2017

Cc: p...@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a022a07a4b44fef77540b75b371230326eed1664

commit a022a07a4b44fef77540b75b371230326eed1664
Author: hans <hans@chromium.org>
Date: Fri Jun 16 02:03:49 2017

Roll clang 305281:305462.

Bug= 733692 

Review-Url: https://codereview.chromium.org/2937203003
Cr-Commit-Position: refs/heads/master@{#479920}

[modify] https://crrev.com/a022a07a4b44fef77540b75b371230326eed1664/tools/clang/scripts/update.py

Comment 12 by p...@chromium.org, Jun 16 2017

Filed  issue 733892  for the next roll.

Comment 13 by h...@chromium.org, Jun 19 2017

Status: Fixed (was: Started)

Sign in to add a comment