New issue
Advanced search Search tips

Issue 733688 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
d...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add a common presubmit check for vpython configs.

Project Member Reported by qyears...@chromium.org, Jun 15 2017 
There is a way to check correctness of vpython configs:

 vpython -dev -spec path/to/common.vpython verify

Since vpython is generally useful for Python used throughout the Chromium codebase, and we expect to be adding more vpython configs, I think it makes sense to add a presubmit check for changes to any files ending in ".vpython" throughout Chromium (in src/PRESUBMIT.py). It probably makes sense to add this as a canned check for convenience in use in presubmits in other repos too.

Comment 1 by d...@chromium.org, Jun 15 2017 

Note that this check is an online check, as it actually validates the packages against live CIPD service. This is good (b/c vpython uses the live CIPD service), but introduces a potential point of failure.
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 18 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment