[WebPayments] VoiceOver usability fixes |
|||
Issue descriptionHere's the a11y issues I've noticed so far using VoiceOver: - Contents of rows are ignored (text is not read, buttons are not navigable) - Contents of sheets other than the top sheet on the stack are discoverable and interfere with navigation - Using tab to navigate (rather than VO shortcuts) traverses different elements, sometimes creating inconsistency of what VO thinks is selected and what actually is selected - Initial focus is usually on a button (e.g. cancel) or field, instead of the top of the sheet - Image buttons (back arrows, and pencils if they were traversable) have no descriptions Some of these may apply on multiple platforms; if so, we can break them out into their own bugs and mark them as blocking.
,
Jun 21 2017
Update! Things are working much, much better. A few nits left, but they are much less severe. These are likely cross-platform issues: - The order summary row does not include a preview of the content (just the row title). This might be OK, since it is marked as a button and clicking the button navigates to the same content in readable form. - The payment method row does not include a preview of the content (just the row title). - We start reading with the focused element, rather than the top of the sheet. - Error strings (e.g., "Email address required") are not read when navigating in a list. (Note, this is NOT an issue in the editors, where errors work correctly) - We don't indicate which row (e.g., which address) is selected when navigating in a list. These are likely Mac bugs: - The text preceding the link in "You can manage them in Settings" and the link must be navigated separately (i.e., the sentence is only read out up until the link). - The buttons inside a row (e.g., choose/add on the summary screen, or edit pencils on the address lists) are not navigable.
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69ad872ecf7a6d4bfebf69a4c18544146ef85433 commit 69ad872ecf7a6d4bfebf69a4c18544146ef85433 Author: tmartino <tmartino@chromium.org> Date: Fri Jun 23 15:58:48 2017 This CL corrects issues with screen reader accessibility on the order summary screen. Specifically: - Does not read the "preview" text (e.g., "123 Fake St. and 1 other...") as it is confusingly similar to the selected state. - Adds accessible content when a payment method has been selected. BUG= 733684 Review-Url: https://codereview.chromium.org/2956473002 Cr-Commit-Position: refs/heads/master@{#481907} [modify] https://crrev.com/69ad872ecf7a6d4bfebf69a4c18544146ef85433/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
,
Jun 27 2017
,
Jul 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec0692492372831f66a7df70527bc1af127f9b65 commit ec0692492372831f66a7df70527bc1af127f9b65 Author: Tommy Martino <tmartino@chromium.org> Date: Tue Jul 04 21:02:54 2017 [WebPayments] a11y: Focusing sheet title Focusing sheet title when switching to new sheet in a11y mode. Bug: 733684 Change-Id: Ia8917612938b68cf661a09d0813d77c5e9610df9 Reviewed-on: https://chromium-review.googlesource.com/556345 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#484156} [modify] https://crrev.com/ec0692492372831f66a7df70527bc1af127f9b65/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc [modify] https://crrev.com/ec0692492372831f66a7df70527bc1af127f9b65/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h [modify] https://crrev.com/ec0692492372831f66a7df70527bc1af127f9b65/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc [modify] https://crrev.com/ec0692492372831f66a7df70527bc1af127f9b65/chrome/browser/ui/views/payments/payment_request_views_util.cc [modify] https://crrev.com/ec0692492372831f66a7df70527bc1af127f9b65/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc [modify] https://crrev.com/ec0692492372831f66a7df70527bc1af127f9b65/chrome/browser/ui/views/payments/view_stack.cc
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ab7351f6694cbcf7306cfeacb10698e95b1a92e commit 7ab7351f6694cbcf7306cfeacb10698e95b1a92e Author: Tommy Martino <tmartino@chromium.org> Date: Wed Jul 12 21:47:33 2017 [WebPayments] Refactoring ItemList::Item This CL changes PaymentRequestItemList::Item from "creates-a" RowView to "is-a" RowView. This was suggested as a good structural change, since it allows the logic of Item to modify the RowView after create-time; in particular, it is necessary now to make an a11y fix (also in this CL). Bug: 733684 Change-Id: I50b71059940208f0ab7146fd4595653cdb586e0a Reviewed-on: https://chromium-review.googlesource.com/565329 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#486100} [modify] https://crrev.com/7ab7351f6694cbcf7306cfeacb10698e95b1a92e/chrome/browser/ui/views/payments/payment_method_view_controller.cc [modify] https://crrev.com/7ab7351f6694cbcf7306cfeacb10698e95b1a92e/chrome/browser/ui/views/payments/payment_request_item_list.cc [modify] https://crrev.com/7ab7351f6694cbcf7306cfeacb10698e95b1a92e/chrome/browser/ui/views/payments/payment_request_item_list.h [modify] https://crrev.com/7ab7351f6694cbcf7306cfeacb10698e95b1a92e/chrome/browser/ui/views/payments/payment_request_item_list_unittest.cc [modify] https://crrev.com/7ab7351f6694cbcf7306cfeacb10698e95b1a92e/chrome/browser/ui/views/payments/payment_request_row_view.cc [modify] https://crrev.com/7ab7351f6694cbcf7306cfeacb10698e95b1a92e/chrome/browser/ui/views/payments/payment_request_row_view.h [modify] https://crrev.com/7ab7351f6694cbcf7306cfeacb10698e95b1a92e/chrome/browser/ui/views/payments/payment_request_sheet_controller.h [modify] https://crrev.com/7ab7351f6694cbcf7306cfeacb10698e95b1a92e/chrome/browser/ui/views/payments/profile_list_view_controller.cc [modify] https://crrev.com/7ab7351f6694cbcf7306cfeacb10698e95b1a92e/chrome/browser/ui/views/payments/shipping_option_view_controller.cc [modify] https://crrev.com/7ab7351f6694cbcf7306cfeacb10698e95b1a92e/components/payments_strings.grdp
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7824443b83123c14b1d500cad6a58ebb5e3634c3 commit 7824443b83123c14b1d500cad6a58ebb5e3634c3 Author: Tommy Martino <tmartino@chromium.org> Date: Thu Jul 13 20:15:33 2017 [WebPayments] Adding a11y for profile errors This CL adds accessible content ensuring that errors (e.g., "Email address required") will be read when navigating to the respective profile. Bug: 733684 Change-Id: I595736de370645656964ddd85fc7d7edb02142b9 Reviewed-on: https://chromium-review.googlesource.com/568242 Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#486468} [modify] https://crrev.com/7824443b83123c14b1d500cad6a58ebb5e3634c3/chrome/browser/ui/views/payments/payment_request_views_util.cc [modify] https://crrev.com/7824443b83123c14b1d500cad6a58ebb5e3634c3/components/payments_strings.grdp
,
Jul 13 2017
The issues identified as "likely cross-platform" have now been resolved. The Mac issue "The text preceding the link in "You can manage them in Settings" and the link must be navigated separately (i.e., the sentence is only read out up until the link)" appears to be WAI based on behavior in other similar circumstances. Two outstanding problems have been broken off into separate issues for further study: crbug.com/742531 -- Screen reader does not always focus on title crbug.com/742538 -- The buttons inside a row are not navigable |
|||
►
Sign in to add a comment |
|||
Comment 1 by tmartino@chromium.org
, Jun 21 2017