The font used by dictionary answers is too small |
|||
Issue descriptionThey are intended to have the same size as standard suggestion text but instead have a smaller size font on Windows (see attached screenshot). This is because the "standard size" answer fonts in chrome/browser/ui/views/omnibox/omnibox_result_view.cc use ui::ResourceBundle::BaseFont while all of the non-answer text in the omnibox and suggestions list uses and adjusted size based (I think) on the logic in LocationBarView::Init(): https://cs.chromium.org/chromium/src/chrome/browser/ui/views/location_bar/location_bar_view.cc?l=158-163&rcl=2acdcced51403c0b6d0ed515f0e86d432a901839 The standard answer types should be made to use this same derived font.
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/720ecfbbc6d951e02e1025b26eeecbc79d9dfedf commit 720ecfbbc6d951e02e1025b26eeecbc79d9dfedf Author: jdonnelly <jdonnelly@chromium.org> Date: Wed Jun 21 22:27:32 2017 Use the result view font list for the base answers font. BUG= 733681 Review-Url: https://codereview.chromium.org/2943533002 Cr-Commit-Position: refs/heads/master@{#481332} [modify] https://crrev.com/720ecfbbc6d951e02e1025b26eeecbc79d9dfedf/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
,
Jun 22 2017
,
Jun 27 2017
jdonnelly@, As per the above(Comment#0) screenshot, No suggestion text observed in the omnibox for the text on Windows latest dev#61.0.6141.0. Please find the attached screencast for reference & please provide us exact steps & expected result to test this issue from our end Thanks..!! |
|||
►
Sign in to add a comment |
|||
Comment 1 by jdonnelly@chromium.org
, Jun 15 2017