New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733663 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Please use my @vewd.com account ins...
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

generate_build_files failing on chromium.perf/Linux Builder

Project Member Reported by ashleymarie@chromium.org, Jun 15 2017

Issue description

generate_build_files failing on chromium.perf/Linux Builder

Builders failed on: 
- Linux Builder: 
  https://build.chromium.org/p/chromium.perf/builders/Linux%20Builder

""" to /b/c/b/Linux_Builder/src/out/Release/args.gn.
/b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check --runtime-deps-list-file=/b/c/b/Linux_Builder/src/out/Release/runtime_deps
  -> returned 1
ERROR at //extensions/shell/installer/linux/BUILD.gn:16:8: Undefined identifier
assert(enable_extensions,
       ^----------------
See //extensions/shell/installer/BUILD.gn:23:7: which caused the file to be included.
      "//extensions/shell/installer/linux",
      ^-----------------------------------
GN gen failed: 1
 
Owner: hu...@opera.com
Looks like it was this change: https://codereview.chromium.org/2904443004

Comment 2 by most...@opera.com, Jun 15 2017

Cc: hu...@opera.com
Owner: most...@opera.com
Status: Started (was: Available)

Comment 4 by hu...@opera.com, Jun 15 2017

Issue 733732 has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f83c87ba32eea432dfc59a1079ad6218ee230e57

commit f83c87ba32eea432dfc59a1079ad6218ee230e57
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Thu Jun 15 19:32:03 2017

add missing import for enable_extensions

BUG= 733663 , 725906 
TBR=brettw

Change-Id: I2c4b30ac5c93372952f7f3901929afc57bef6572
Reviewed-on: https://chromium-review.googlesource.com/537372
Reviewed-by: Mostyn Bramley-Moore <mostynb@opera.com>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#479784}
[modify] https://crrev.com/f83c87ba32eea432dfc59a1079ad6218ee230e57/extensions/shell/installer/linux/BUILD.gn

Comment 6 by most...@opera.com, Jun 15 2017

Status: Fixed (was: Started)
Fix landed, and those bots look green again.

Sign in to add a comment