NavigationManagerUtilTest.GetCommittedItemWithUniqueID failing with a DCHECK |
||||
Issue descriptionThe test was moved to a separate target by mistake and not run for a full month. It is now failing with the following DCHECK: [ RUN ] NavigationManagerUtilTest.GetCommittedItemWithUniqueID [89297:1027:0615/170857.740608:805037797237892:FATAL:crw_session_controller.mm(287)] Check failed: _browserState == _navigationManager->GetBrowserState() (0x60800019f738 vs. 0x0)
,
Jun 16 2017
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d66e427b3ec59b4a71a80c4dc79c74ef4f3f25a commit 2d66e427b3ec59b4a71a80c4dc79c74ef4f3f25a Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Jun 16 13:29:54 2017 [ios] Fix ios_web_unittests & ios_web_unittests_arc state. Something weird happened when ios_web_unittests was split during the conversion to ARC, causing some of the test to no longer be run. Remove ios_web_unittests_arc and instead move the files to the correct *_unittest target. Disable a test that was broken by some refactoring as it was not run on the bot (since they don't run ios_web_unittests_arc). BUG= 733658 Change-Id: Idb8d23aa63fe6ca25d175c435a4dc7b0c18e0173 Reviewed-on: https://chromium-review.googlesource.com/536939 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#480028} [modify] https://crrev.com/2d66e427b3ec59b4a71a80c4dc79c74ef4f3f25a/ios/web/BUILD.gn [modify] https://crrev.com/2d66e427b3ec59b4a71a80c4dc79c74ef4f3f25a/ios/web/navigation/navigation_manager_util_unittest.mm
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3cb2e604616779b44a1f900dfaa50aa565b23a5 commit d3cb2e604616779b44a1f900dfaa50aa565b23a5 Author: kkhorimoto <kkhorimoto@chromium.org> Date: Wed Jun 21 22:40:23 2017 Fix failing NavigationManagerUtil test that wasn't being run. This test was added to a suite that was not properly connected to the waterfall, and has been failing silently. BUG= 733658 Review-Url: https://codereview.chromium.org/2942103002 Cr-Commit-Position: refs/heads/master@{#481336} [modify] https://crrev.com/d3cb2e604616779b44a1f900dfaa50aa565b23a5/ios/web/BUILD.gn [modify] https://crrev.com/d3cb2e604616779b44a1f900dfaa50aa565b23a5/ios/web/navigation/navigation_manager_util_unittest.mm [modify] https://crrev.com/d3cb2e604616779b44a1f900dfaa50aa565b23a5/ios/web/test/BUILD.gn [add] https://crrev.com/d3cb2e604616779b44a1f900dfaa50aa565b23a5/ios/web/test/fakes/BUILD.gn [add] https://crrev.com/d3cb2e604616779b44a1f900dfaa50aa565b23a5/ios/web/test/fakes/test_navigation_manager_delegate.h [add] https://crrev.com/d3cb2e604616779b44a1f900dfaa50aa565b23a5/ios/web/test/fakes/test_navigation_manager_delegate.mm
,
Jun 22 2017
,
Jan 24 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sdefresne@chromium.org
, Jun 15 2017Labels: ReleaseBlock-Beta M-61