VR: Add drag support for the content |
||||||||||||||||||||
Issue descriptionWe have disabled drag support in VR because it was very difficult to click on links. We need to add it back and make sure the noisiness of the controller doesn't affect usability.
,
Aug 11 2017
This is related to issue 740001.
,
Oct 20 2017
,
Oct 20 2017
This should be solved by us changing to stylus-style input, where instead of sending mouse down/move/up, we send touch down/move/up.
,
Nov 22 2017
,
Jan 17 2018
Assigning to Amir as he's working on changing our input to sending touch events.
,
Jan 17 2018
,
Feb 28 2018
This is actually independent from the move to using touch events (which we now do). If we ever want to support fling kinetic scrolling we'll have to solve this problem so that we can actually create clicks instead of always flinging :)
,
Feb 28 2018
,
Apr 5 2018
Since this affects compat with websites ( issue 829135 ), I don't think we should let this linger
,
Apr 5 2018
,
May 24 2018
,
May 24 2018
,
May 24 2018
,
May 29 2018
,
Jun 5 2018
,
Jun 7 2018
What's the plan for this issue? Do you want to disable dragging while in VR mode? The related codes are here: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/input/mouse_event_manager.cc?q=mouse_event_manager&sq=package:chromium&dr=C&l=961 You can also change the threshold and related stuff there in the same file. If the controller is too noisy how would the user actually show the intention for the dragging? Do we even have that usecase in VR?
,
Jun 7 2018
We don't want to disable dragging in VR. We basically want the reticle (the VR equivalent of mouse cursor) to act like a finger when you click the touch pad on the daydream controller. So when we say dragging, we mean mobile dragging, where you scroll/fling from drag rather than perform selection. A while ago, when this bug was filed, we were injecting mouse events directly into RFH(?), so it assumed no noise, and basically any movement at all converted our clicks into selection/drag. However, we now inject touch events through the Android input path, which already has some slop region for treating the finger moving as a click. Aldo is evaluating whether or not we'll need that touch slop increased - I'm not sure whether the controller is noisier or less noisy than a finger.
,
Jun 12 2018
,
Jun 12 2018
,
Jun 13 2018
,
Jun 13 2018
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d51d342022e6950032e02ad06c2aabb82c0a1c49 commit d51d342022e6950032e02ad06c2aabb82c0a1c49 Author: Aldo Culquicondor <acondor@chromium.org> Date: Fri Jun 15 18:42:36 2018 VR: Adding move support for the platform UI This enables touch interaction with the web contents, effectively enabling long press, drag, selection, etc. Context menu and selection handles are disabled for VR in this CL. Bug: 842916 , 733656 , 848740 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr Change-Id: If50401ddbc130abde697b57d580bc492de2c4dda Reviewed-on: https://chromium-review.googlesource.com/1091281 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#567745} [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/DEPS [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/android/vr/android_ui_gesture_target.cc [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/ui/android/context_menu_helper.cc [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/content_input_delegate.cc [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/content_input_delegate.h [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/elements/platform_ui_element.cc [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/elements/platform_ui_element.h [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/platform_ui_input_delegate.cc [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/platform_ui_input_delegate.h [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/ui.cc [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/ui_suppressed_element.h [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/chrome/browser/vr/vr_tab_helper.cc [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/d51d342022e6950032e02ad06c2aabb82c0a1c49/tools/metrics/histograms/enums.xml
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39e21957a9d9790c1e036b3c103c30e3917dc4ed commit 39e21957a9d9790c1e036b3c103c30e3917dc4ed Author: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Date: Mon Jun 18 10:38:34 2018 Revert "VR: Adding move support for the platform UI" This reverts commit d51d342022e6950032e02ad06c2aabb82c0a1c49. Reason for revert: A DCHECK is failing on the bots, see bug 853388. Original change's description: > VR: Adding move support for the platform UI > > This enables touch interaction with the web contents, effectively > enabling long press, drag, selection, etc. > > Context menu and selection handles are disabled for VR in this CL. > > Bug: 842916 , 733656 , 848740 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr > Change-Id: If50401ddbc130abde697b57d580bc492de2c4dda > Reviewed-on: https://chromium-review.googlesource.com/1091281 > Commit-Queue: Aldo Culquicondor <acondor@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567745} TBR=sky@chromium.org,mthiesse@chromium.org,jam@chromium.org,tedchoc@chromium.org,tdresser@chromium.org,acondor@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 842916 , 733656 , 848740 , 853388 Change-Id: I24b609f9c2c92efde74b53020a44907e0a30627e Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr Reviewed-on: https://chromium-review.googlesource.com/1104217 Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#567965} [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/DEPS [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/android/vr/android_ui_gesture_target.cc [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/ui/android/context_menu_helper.cc [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/content_input_delegate.cc [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/content_input_delegate.h [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/elements/platform_ui_element.cc [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/elements/platform_ui_element.h [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/platform_ui_input_delegate.cc [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/platform_ui_input_delegate.h [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/ui.cc [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/ui_suppressed_element.h [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/chrome/browser/vr/vr_tab_helper.cc [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/39e21957a9d9790c1e036b3c103c30e3917dc4ed/tools/metrics/histograms/enums.xml
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53195553e54ad8cc0441aa06f33e7c15cf198eef commit 53195553e54ad8cc0441aa06f33e7c15cf198eef Author: Aldo Culquicondor <acondor@chromium.org> Date: Tue Jun 19 21:53:13 2018 Reland "VR: Adding move support for the platform UI" This is a reland of d51d342022e6950032e02ad06c2aabb82c0a1c49 Previously, we were DCHECKing that touch handles were not being enabled during VR browsing. This caused some tests to crash, since the VR browser can not control when those calls are produced. Instead, this CL merges all the requirements for disabling the touch handles, including the VR mode. Original change's description: > VR: Adding move support for the platform UI > > This enables touch interaction with the web contents, effectively > enabling long press, drag, selection, etc. > > Context menu and selection handles are disabled for VR in this CL. > > Bug: 842916 , 733656 , 848740 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr > Change-Id: If50401ddbc130abde697b57d580bc492de2c4dda > Reviewed-on: https://chromium-review.googlesource.com/1091281 > Commit-Queue: Aldo Culquicondor <acondor@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567745} Bug: 842916 , 733656 , 848740 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I405c57fb91324758834f2d7afe21bb9c2bc937d4 Reviewed-on: https://chromium-review.googlesource.com/1104638 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#568609} [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/DEPS [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/android/vr/android_ui_gesture_target.cc [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/ui/android/context_menu_helper.cc [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/content_input_delegate.cc [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/content_input_delegate.h [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/elements/platform_ui_element.cc [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/elements/platform_ui_element.h [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/platform_ui_input_delegate.cc [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/platform_ui_input_delegate.h [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/ui.cc [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/ui_suppressed_element.h [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/chrome/browser/vr/vr_tab_helper.cc [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/content/browser/renderer_host/render_widget_host_view_android.h [modify] https://crrev.com/53195553e54ad8cc0441aa06f33e7c15cf198eef/tools/metrics/histograms/enums.xml
,
Jun 20 2018
,
Jun 25 2018
|
||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||
Comment 1 by vollick@chromium.org
, Aug 9 2017