New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733644 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

run-bisect-manual-test.py crashes: 'module' object has no attribute 'GetTelemetryDir'

Project Member Reported by skobes@chromium.org, Jun 15 2017

Issue description

Getting the following in a freshly sync'ed Linux checkout:

$ tools/run-bisect-manual-test.py

Traceback (most recent call last):
  <module> at /b/c/src/tools/run-bisect-manual-test.py:33
    sys.path.append(chromium_config.GetTelemetryDir())
AttributeError: 'module' object has no attribute 'GetTelemetryDir'

Locals:
  CROS_BOARD_ENV      : 'BISECT_CROS_BOARD'
  CROS_IP_ENV         : 'BISECT_CROS_IP'
  _BISECT_SCRIPT_PATH : '/b/c/src/tools/auto_bisect/bisect_perf_regression.py'
  _TOOLS_DIR          : '/b/c/src/tools'
  __builtins__        : <module '__builtin__' (built-in)>
  __doc__             : "Run Manual Test Bisect Tool\n\nAn example usage:\ntools/run-bisect-manual-test.py -g 201281 -b 201290\n\nOn Linux platform, follow the instructions in this document\nhttps://chromium.googlesource.com/chromium/src/+/master/docs/linux_suid_sandbox_development.md\nto setup the sandbox manually before running the script. Otherwise the script\nfails to launch Chrome and exits with an error.\n\nThis script serves a similar function to bisect-builds.py, except it uses\nthe bisect_perf_regression.py. This means that that it can obtain builds of\nChromium for revisions where builds aren't available in cloud storage.\n"
  __file__            : 'tools/run-bisect-manual-test.py'
  __name__            : '__main__'
  __package__         : None
  chromium_config     : <module 'chrome_telemetry_build.chromium_config' from '/b/c/src/tools/perf/chrome_telemetry_build/chromium_config.pyc'>
  os                  : <module 'os' from '/usr/lib/python2.7/os.pyc'>
  subprocess          : <module 'subprocess' from '/usr/lib/python2.7/subprocess.pyc'>
  sys                 : <module 'sys' (built-in)>
 

Comment 1 by hjd@chromium.org, Jun 29 2017

I think this is the fix: https://chromium-review.googlesource.com/c/555892/
Looks like GetTelemetryDir was lost from chromium_config here: https://codereview.chromium.org/2824053002

Comment 2 by hjd@chromium.org, Jun 29 2017

Cc: hjd@chromium.org
Labels: TE-NeedsTriageHelp
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 11

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment