New issue
Advanced search Search tips

Issue 733612 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make test_env.py and xvfb.py propagate signals correctly

Project Member Reported by mar...@chromium.org, Jun 15 2017

Issue description

When it receives a SIGTERM / CTRL_BREAK_EVENT, it shall propagate it to child processes.

This is required for proper Swarming timeout handling. See https://github.com/luci/luci-py/blob/master/appengine/swarming/doc/Bot.md#graceful-termination-aka-the-sigterm-and-sigkill-dance

Filing one bug for both scripts since it can be done in one shot.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 15 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by mar...@chromium.org, Jun 15 2018

Cc: bpastene@chromium.org
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Ben looked at this recently. It'd be nice.
Components: -Test Infra>Client>Chrome
Owner: bpastene@chromium.org
Status: Assigned (was: Available)
Ohhhhhhh, that's probably why https://chromium-review.googlesource.com/1087800 doesn't work in practice on swarming.

Thanks for pointing that out. I'll handle this.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5ece81fab9147defb70bc3209ae8e8cd8167eeb

commit e5ece81fab9147defb70bc3209ae8e8cd8167eeb
Author: Ben Pastene <bpastene@chromium.org>
Date: Wed Jun 20 22:39:34 2018

Make test_env.py forward swarming's timeout signals.

This will let any test invoked via test_env.py on swarming handle timeouts.

This should also cover xvfb.py:
https://chromium.googlesource.com/chromium/src/+/master/testing/xvfb.py#97

Bug: 733612,  848402 
Change-Id: I33242bd6fe86072f0b32150eab6b878436252388
Reviewed-on: https://chromium-review.googlesource.com/1105022
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569055}
[modify] https://crrev.com/e5ece81fab9147defb70bc3209ae8e8cd8167eeb/testing/test_env.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95a2d330a7d9407936e1015a8b1ae4266150e827

commit 95a2d330a7d9407936e1015a8b1ae4266150e827
Author: Andrew Grieve <agrieve@chromium.org>
Date: Thu Jun 28 02:22:59 2018

Fix crash in timeout signal handler within testing/test_env.py

Noticed this from:
https://chromium-swarm.appspot.com/task?id=3e5bfa5ea894bf10&refresh=10&show_raw=1&wide_logs=true

Post stating it's win32 only:
https://github.com/python/mypy/issues/3872

Bug: 733612
Change-Id: I7bd8fc20e4793a225e093450ba902ae525af8ac9
Reviewed-on: https://chromium-review.googlesource.com/1117858
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570999}
[modify] https://crrev.com/95a2d330a7d9407936e1015a8b1ae4266150e827/testing/test_env.py

Sign in to add a comment