New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733599 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocked on:
issue angleproject:2101

Blocking:
issue 612542
issue 751883
issue 878920



Sign in to add a comment

WebGL (1 and 2) canvas data source with width/height >256 + Luminance => fail

Reported by steph...@sketchfab.com, Jun 15 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.86 Safari/537.36

Steps to reproduce the problem:
1. Go to https://jsfiddle.net/spnc4vno/
2. black result
3. 

What is the expected behavior?
gradient

What went wrong?
black instead of gradient

Did this work before? Yes no idea

Does this work in other browsers? Yes

Chrome version: 59.0.3071.86  Channel: stable
OS Version: 10.0
Flash Version: 

If the width and height of the canvas is below or equals 256 it works fine, higher than that and I receive:

[.Offscreen-For-WebGL-000002B1689CF5E0]GL ERROR :GL_INVALID_OPERATION : glCopySubTextureCHROMIUM: invalid dest internal format GL_LUMINANCE
 
The code snippet is using mipmap but the bug occurs without them too.
Cc: ranjitkan@chromium.org pbomm...@chromium.org abdulsyed@chromium.org qiankun....@intel.com brajkumar@chromium.org
Labels: -Pri-2 hasbisect-per-revision ReleaseBlock-Stable M-59 OS-Linux OS-Mac Pri-1
Owner: kbr@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce on Windows-10, Ubuntu 14.04 and Mac OS 10.12.5 using chrome latest stable #59.0.3071.86.

Bisect Information:
--------------------
Good build: 59.0.3066.0
Bad Build : 59.0.3068.1 

You are probably looking for a change made after 463268 (known good), but no later than 463269 (first known bad).

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/0338b35867900b81de5e6960eec0572f152974b7..03b5cd7ff9b0c8457efe2578d18de91141be30b6

From the above change log suspecting below change
Review-Url: https://codereview.chromium.org/2738163002

qiankun.miao/kbr@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Since this is a recent regression broke in M-59 adding RB-Stable, Please feel free to remove if this is not the case. 

Thanks!

Comment 3 by kbr@chromium.org, Jun 17 2017

Blocking: 612542
It's almost certain that using the GPU-to-GPU copy path for this case regressed it because the 256-size boundary is the point at which 2D canvas contexts are accelerated.

Just need to debug the code path and fix it.

Comment 4 by kbr@chromium.org, Jun 19 2017

Labels: -ReleaseBlock-Stable -M-59
Sorry, but since this made it out to Stable it is by definition not a release blocker for Stable. Removing the label.

Submitter, I strongly encourage you to test with Chrome Beta and Dev (or Canary) to catch issues like this earlier.

Comment 5 by kbr@chromium.org, Jul 10 2017

Blocking: angleproject:2101

Comment 6 by kbr@chromium.org, Jul 10 2017

Blocking: -angleproject:2101

Comment 7 by kbr@chromium.org, Jul 10 2017

Blockedon: angleproject:2101
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b642ce1b14a2b5d9ef78fd1b9ae2b5d6ae1c9cb9

commit b642ce1b14a2b5d9ef78fd1b9ae2b5d6ae1c9cb9
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Jul 13 05:33:44 2017

Support LUMINANCE, ALPHA, and LUMINANCE_ALPHA in CopyTextureCHROMIUM.

Use the luminance/alpha emulation blitter for CopyTex{Sub}Image2D on
the Core Profile to support these.

Simplified the copy shader and fixed bugs in handling of premul/unmul
which are tested by the new tests in
https://github.com/KhronosGroup/WebGL/pull/2451 .

BUG= 733599 

Change-Id: Ic52b318d917dd95b8eb2c8fa3ce7b2aaebc24a63
Reviewed-on: https://chromium-review.googlesource.com/567306
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486281}
[modify] https://crrev.com/b642ce1b14a2b5d9ef78fd1b9ae2b5d6ae1c9cb9/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc
[modify] https://crrev.com/b642ce1b14a2b5d9ef78fd1b9ae2b5d6ae1c9cb9/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc
[modify] https://crrev.com/b642ce1b14a2b5d9ef78fd1b9ae2b5d6ae1c9cb9/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
[modify] https://crrev.com/b642ce1b14a2b5d9ef78fd1b9ae2b5d6ae1c9cb9/gpu/command_buffer/service/gles2_cmd_decoder.cc

Comment 9 by kbr@chromium.org, Jul 13 2017

Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d36daf872d9601f32503e3c1f101e8d1395a4aa5

commit d36daf872d9601f32503e3c1f101e8d1395a4aa5
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Jul 14 21:13:41 2017

Roll WebGL 5e57726..72eda82

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/5e57726..72eda82

BUG= 733599 , 735483,  angleproject:2103 
TEST=bots
TBR=zmo@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I4542a243a3b34141becea64e1f024872f64c3ce2
Reviewed-on: https://chromium-review.googlesource.com/570761
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486889}
[modify] https://crrev.com/d36daf872d9601f32503e3c1f101e8d1395a4aa5/DEPS
[modify] https://crrev.com/d36daf872d9601f32503e3c1f101e8d1395a4aa5/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/d36daf872d9601f32503e3c1f101e8d1395a4aa5/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/d36daf872d9601f32503e3c1f101e8d1395a4aa5/content/test/gpu/gpu_tests/webgl_conformance_revision.txt

Comment 11 by kbr@chromium.org, Jul 14 2017

Labels: M-61
Status: Fixed (was: Started)
This will be fixed in Chrome 61.

Comment 12 by kbr@chromium.org, Aug 8 2017

Blocking: 751883
Blocking: 878920

Sign in to add a comment