New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733595 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.7%-4.8% regression in system_health.memory_desktop at 478959:479146

Project Member Reported by mlippautz@google.com, Jun 15 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jun 15 2017

Cc: alexclarke@chromium.org
Owner: alexclarke@chromium.org

=== Auto-CCing suspected CL author alexclarke@chromium.org ===

Hi alexclarke@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Alex Clarke
  Commit : fd98b65e68c329ff0bb43db5a1c15e50aaa6c66d
  Date   : Tue Jun 13 15:44:08 2017
  Subject: Fix logic to flush internal scheduler state on navigation comit.

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/browse_search/browse_search_google
  Change       : 5.63% | 14889412.0 -> 15728301.3333

Revision             Result                  N
chromium@478963      14889412 +- 223539      6      good
chromium@479009      14933495 +- 210006      6      good
chromium@479021      14919925 +- 163801      6      good
chromium@479027      14881743 +- 285314      6      good
chromium@479029      14865427 +- 274972      6      good
chromium@479030      15714843 +- 196075      6      bad       <--
chromium@479032      15830969 +- 564522      6      bad
chromium@479055      15728301 +- 423354      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.search.google system_health.memory_desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976725376158487232

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5788711670775808


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 15 2017

Cc: tebbi@chromium.org
 Issue 733246  has been merged into this issue.
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jun 16 2017

 Issue 733955  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jun 16 2017

 Issue 734010  has been merged into this issue.
Status: WontFix (was: Untriaged)
Curious there's no links to the graphs in this bug.

The original commit (https://chromium-review.googlesource.com/522069) caused a bunch of memory perf regressions which this fixed.  Any perf change good or bad caused by that where unintended. Looking at one of the duplicate bugs we can see that the graphs have reverted to the previous mean.

https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtum0rgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg1vHPqQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtoKytAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg1uPCtQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtvG6tAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgtqiFvQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgttyYoAsM

 Issue 733594  has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jun 19 2017

 Issue 733956  has been merged into this issue.

Sign in to add a comment