New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733590 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.1%-12.4% regression in webrtc_perf_tests at 18450:18450

Project Member Reported by terelius@chromium.org, Jun 15 2017

Issue description

Memory usage and CPU time increased after enabling VP9 denoising.

https://chromium.googlesource.com/external/webrtc/+/6bf57e346794950aec9a789ea906e3d14ba9a6e2

 
Cc: brandtr@chromium.org
Owner: jianj@chromium.org
Over to Jerome to verify that the perf changes (~12% more memory, ~2% more CPU) are reasonable.

Comment 3 by jianj@chromium.org, Jun 16 2017

Cc: marpan@chromium.org

Comment 4 by jianj@chromium.org, Jun 23 2017

~2% more cpu usage is expected since the denoiser is enabled.

The memory usage is probably caused by the extra ref frame buffers allocated by the denoiser. It allocates another 4 reference frame buffers. 
It should be safe to remove the alt-ref such that the memory usage can be reduced by 1/4.
I'll make a change to address it next week.

Comment 5 by jianj@chromium.org, Jul 18 2017

Status: Fixed (was: Assigned)
The change to remove alt-ref from vp9 denoiser has been rolled in. The graph shows the memory usage is reduced by approximately 1/4 of the memory usage increase in this issue.


Sign in to add a comment