New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733566 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Translation cache of pexe in resources.pak is never invalidated

Project Member Reported by yawano@chromium.org, Jun 15 2017

Issue description

Chrome Version: ToT
OS: Chrome

What steps will reproduce the problem?
(1) Make any change in the native code of zip archiver. files under ui/file_manager/zip_archiver/cpp
(2) Deploy the change to the device by using Simple Chrome.
(3) Check whether your changes are reflected or not.

What is the expected result?
Those changes should be reflected on the device.

What happens instead?
It seems that those changes are not reflected on the device.

Additional info
- If I test the change with linux_chromeos, those change are reflected.
- Those files are compiled. If I put some error in those file, the compile fails.
- zip_archiver_pnacl.pexe is updated if I make a change in the native code.
- Size of resources.pak changes if I make a change in the native code.
- If I check the size of resources.pak on the device, it matches with the size with the output on the workstation. It seems that resources.pak are correctly transferred to the device.
 

Comment 1 by yawano@chromium.org, Jun 16 2017

Components: Platform>NaCl
Status: Assigned (was: Started)
Summary: Translation cache of pexe in resources.pak is never invalidated (was: zip archiver: native code changes are not reflected on the device)
Found the cause of this issue. pnacl_translation_cache is using last modified as a part of its key.

https://cs.chromium.org/chromium/src/components/nacl/browser/pnacl_translation_cache.cc?l=405

Response for resources.pak seems not contain last-modified header.

https://cs.chromium.org/chromium/src/components/nacl/renderer/ppb_nacl_private_impl.cc?l=1626

It means that last modified for the pexe is set to 0. The translation cache is never invalidated for this case.

Comment 2 by yawano@chromium.org, Jun 21 2017

Cc: hirono@chromium.org
As we are loading pexe of piex from resources.pak, it should share the same problem.

https://cs.chromium.org/chromium/src/ui/file_manager/file_manager_resources.grd?l=227

Comment 3 by sashab@chromium.org, Feb 24 2018

Labels: CrOS-FilesApp-CodeHealth

Comment 4 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-CodeHealth CrOSFilesCategory-CodeHealth
Cc: yawano@chromium.org
Owner: ----
Status: Available (was: Assigned)
Status: Archived (was: Available)

Sign in to add a comment