New issue
Advanced search Search tips

Issue 733565 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Tests]: Regression: Lengthy Address in auto-fill settings is overlapping with 3 Dot menu focus

Project Member Reported by krajshree@chromium.org, Jun 15 2017

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
https://chromium.googlesource.com/chromium/src.git/+/e959cddaeca101036a8edf445a5d57c629632afc

Ref Bug: 
https://bugs.chromium.org/p/chromium/issues/detail?id=724944


Thank you...!!
 
 
Cc: dpa...@chromium.org
Owner: krajshree@chromium.org
Is there a testing framework that would be appropriate for IU overlap testing? i.e. is there another existing test that does something similar?

Comment 2 by dpa...@chromium.org, Jun 15 2017

Cc: tommycli@chromium.org
Blink itself has several layout tests, so it is possibe. Having said that, I don't know much about it, especially on whether this can be used easily outside of the Blink codebase.

@tommycli has mentioned in the past that such tests (pixel fidelity, screenshot diffing) are fairly hard and high maintenance.
Yes... those are high maintainence, but in my use case, have caught about 2-3 attempted regressions by other people.

In your guys' case, maybe consider keeping tests that query the pixel location / sizes of elements without taking actual screenshots.
Owner: ----

Sign in to add a comment