New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733545 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Factory: Evaluate if we can eliminate prespawner

Project Member Reported by hungte@chromium.org, Jun 15 2017

Issue description

When factory software was still using autotest, we find that autotest has a very long latency to startup, so a prespawner was introduced to speed up. Pytests, based on unittest, starts much faster so there's no need to use prespawner. However in order to unify the code execution path, we also made a prespawner for pytests.

Now, autotest support is removed and we should evaluate again if using prespawner is really needed. If not, we may simply load and run python module files, to prevent the overhead of serializing session data, communicate via pipe, and reloading modules.

However, this implies the forked process may have heavy initial memory footprint (which comes from Goofy) and we need to measure how this impacts test startup time. (In theory Linux memory will be managed as copy-on-write, but we're not sure how python would make changes to this)
 

Comment 1 by hungte@chromium.org, Jul 14 2017

Cc: -akahuang@chromium.org -stimim@chromium.org chromeos-factory-eng@google.com

Comment 2 by hungte@chromium.org, Jul 26 2017

Owner: pihsun@chromium.org
stimim or pihsun?
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/7279f043a5d1944ec17cfd2d9265536f8353b62b

commit 7279f043a5d1944ec17cfd2d9265536f8353b62b
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Aug 10 12:16:24 2017

prespawner: Add comments on why prespawner is used.

Add some finding in comment from CL:603507 about why prespawner is still
useful after autotest support is dropped.

Also remove some old comment and statements.

BUG= chromium:733545 
TEST=make test

Change-Id: I360fde7fd013da11e9d0818378ec7377212341c3
Reviewed-on: https://chromium-review.googlesource.com/609057
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/7279f043a5d1944ec17cfd2d9265536f8353b62b/py/goofy/invocation.py
[modify] https://crrev.com/7279f043a5d1944ec17cfd2d9265536f8353b62b/py/goofy/prespawner.py

Comment 4 by pihsun@chromium.org, Aug 11 2017

Status: WontFix (was: Untriaged)

Sign in to add a comment