New issue
Advanced search Search tips

Issue 733542 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocked on:
issue 263556



Sign in to add a comment

[Missing Tests]:Regression: Scrollbar doesn't appear with Rubberband effect

Project Member Reported by kavvaru@chromium.org, Jun 15 2017

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
https://chromium.googlesource.com/chromium/src.git/+/4795906652460b283e526e6745057d77f0133980

Ref Bug: 
https://bugs.chromium.org/p/chromium/issues/detail?id=724507

Note : Tagging this as RBS since the base bug is blocker.

Thank you!
 
 
Cc: bokan@chromium.org
Labels: -M-60 M-61
bokan@ Do you think we should add a test for check Mac Overlay Scrollbar not create ScrollbarAnimationController?

Comment 2 by bokan@chromium.org, Jun 15 2017

Blockedon: 263556
Labels: -Pri-2 -ReleaseBlock-Stable Pri-3
A test like that will only check it in a very specific scenario so it wont be much use. A more general browser test that ensures the scrollbar appears with the rubberbanding effect would be better, but Mac scrollbars are difficult to test as they're painted by the OS and highly asynchronous so timing is difficult and would make any test flaky.

Mac scrollbars today in general are missing even basic test coverage (issue 263556), some of the refactoring work we've got on the road map is to make that possible. Unfortunately, this isn't very actionable today but lets block this on issue 263556 to make sure we eventually add it once it's possible.

Removing RBS, this isn't likely to get added in the short term and the underlying bug is already fixed.

Sign in to add a comment